From: Eric Dumazet <eric.dumazet@gmail.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next-2.6] tg3: 64bits stats
Date: Mon, 05 Jul 2010 18:03:00 +0200 [thread overview]
Message-ID: <1278345780.2877.376.camel@edumazet-laptop> (raw)
In-Reply-To: <1278321242.2877.18.camel@edumazet-laptop>
Le lundi 05 juillet 2010 à 11:14 +0200, Eric Dumazet a écrit :
> After commit be1f3c2c027c (net: Enable 64-bit net device statistics on
> 32-bit architectures), we can now provide 64bit stats, even on 32bit
> arches.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
Please disregard this patch.
There is small possibility a reader might read a 64bit value while
another writer makes a change to it, changing high 32bit value.
A change in core network would be needed to make this 100% safe,
possibly using a seqlock to protect dev->stats64
next prev parent reply other threads:[~2010-07-05 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 9:14 [PATCH net-next-2.6] tg3: 64bits stats Eric Dumazet
2010-07-05 16:03 ` Eric Dumazet [this message]
2010-07-05 17:31 ` Ben Hutchings
2010-07-05 18:07 ` Eric Dumazet
2010-07-05 18:30 ` Ben Hutchings
2010-07-05 18:35 ` Eric Dumazet
2010-07-05 18:41 ` Ben Hutchings
2010-07-05 18:59 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278345780.2877.376.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox