From: Eric Dumazet <eric.dumazet@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: Fwd: Possible bug in net/ipv4/route.c?
Date: Mon, 05 Jul 2010 22:18:07 +0200 [thread overview]
Message-ID: <1278361087.2466.107.camel@edumazet-laptop> (raw)
In-Reply-To: <20100705200728.GB11096@khazad-dum.debian.net>
Le lundi 05 juillet 2010 à 17:07 -0300, Henrique de Moraes Holschuh a
écrit :
> On Mon, 05 Jul 2010, Eric Dumazet wrote:
> > Le lundi 05 juillet 2010 à 21:22 +0800, Herbert Xu a écrit :
> > > On Mon, Jul 05, 2010 at 02:59:14PM +0200, Eric Dumazet wrote:
> > > >
> > > > Why do we clear full 48 bytes skb->cb[] in skb_alloc(), if no protocol
> > > > stack should rely it being zero ?
> > >
> > > Unless a protocol is allocating the skb itself, then the fact
> > > that skb_alloc clears skb->cb is no guarantee that the skb->cb
> > > will be zero.
> >
> > I see. We could :
> >
> > Avoid this memset(skb->cb, 0, sizeof(skb->cb)) in fastpath.
>
> Any chances of skb->cb being leaked to userspace or the network, due to
> driver bugs or other such oddities?
>
Not "a priori", but a bug is always possible ;)
cb[] is internal use only, should not be sent to network or user land.
prev parent reply other threads:[~2010-07-05 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 2:49 Fwd: Possible bug in net/ipv4/route.c? YOSHIFUJI Hideaki
2010-07-02 5:38 ` Eric Dumazet
2010-07-05 12:06 ` Herbert Xu
2010-07-05 12:59 ` Eric Dumazet
2010-07-05 13:22 ` Herbert Xu
2010-07-05 13:34 ` Eric Dumazet
2010-07-05 14:42 ` Herbert Xu
2010-07-05 20:07 ` Henrique de Moraes Holschuh
2010-07-05 20:18 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278361087.2466.107.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox