Re: Pull request: bluetooth-2.6 2010-07-08

[Marcel Holtmann <marcel@holtmann.org>]

Hi Dave,

> > these patches fix a few bugs and crashes and also two security related
> > issues with the authentication procedure.
> 
> 13 changes is too much this late in the -RC series.  Fixes need to
> trickle in, in small quantities, and therefore it's critical that
> maintainers submit fixes often and as soon as they are ready.
> 
> Please pick a small number of the most critical fixes, say 3 or 4.  An
> easy way to roughly quantify which ones shoule be included is:
> 
> 1) Is there an OOPS or crash regression reported by real users and
>    listed in the official lkml regression list which is caused by this
>    problem?
> 
> 2) Is there an exploitable security concern fixed by this change?
> 
> Else, it's only net-next-2.6 material.
> 
> For example:
> 
>     Bluetooth: Remove max_tx and tx_window module paramenters from L2CAP
> 
> Things like that change are absolutely not appropriate at this
> stage in the post merge-window development environment.

I can take these out and leave them for -next. That is fine with me, but
you asked Gustavo to remove these. And so I left them in.

Regards

Marcel