From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Rodrigo Partearroyo González" <rpartearroyo@albentia.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Iratxo Pichel Ortiz" <ipichel@albentia.com>,
"Noelia Morón" <nmoron@albentia.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: net/sched/act_nat.c BUG
Date: Sat, 10 Jul 2010 08:27:21 +0200 [thread overview]
Message-ID: <1278743241.2538.28.camel@edumazet-laptop> (raw)
In-Reply-To: <20100709232359.GA2501@gondor.apana.org.au>
Le samedi 10 juillet 2010 à 07:23 +0800, Herbert Xu a écrit :
> No we do need the second IP header, think about it...
>
> However, we should only drop it only if it's long enough and
> pskb_may_pull fails.
Indeed right you are !
As Changli suggested, we need another pskb_may_pull() call.
Thanks
prev parent reply other threads:[~2010-07-10 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201007091637.57660.rpartearroyo@albentia.com>
2010-07-09 15:13 ` net/sched/act_nat.c BUG Eric Dumazet
2010-07-09 23:23 ` Herbert Xu
2010-07-10 0:00 ` David Miller
2010-07-10 6:27 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278743241.2538.28.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=ipichel@albentia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nmoron@albentia.com \
--cc=rpartearroyo@albentia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox