From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Subject: [PATCH] tc35815: fix iomap leak Date: Sat, 10 Jul 2010 14:03:18 +0400 Message-ID: <1278756199-4636-1-git-send-email-segooon@gmail.com> Cc: "David S. Miller" , Atsushi Nemoto , Jiri Pirko , Eric Dumazet , Alexey Dobriyan , netdev@vger.kernel.org To: kernel-janitors@vger.kernel.org Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:64749 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596Ab0GJKDs (ORCPT ); Sat, 10 Jul 2010 06:03:48 -0400 Sender: netdev-owner@vger.kernel.org List-ID: If tc35815_init_one() fails we must unmap mapped regions. Signed-off-by: Kulikov Vasiliy --- drivers/net/tc35815.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index be08b75..99afa5c 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -854,7 +854,7 @@ static int __devinit tc35815_init_one(struct pci_dev *pdev, rc = register_netdev(dev); if (rc) - goto err_out; + goto err_out_iounmap; memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len); printk(KERN_INFO "%s: %s at 0x%lx, %pM, IRQ %d\n", @@ -872,6 +872,8 @@ static int __devinit tc35815_init_one(struct pci_dev *pdev, err_out_unregister: unregister_netdev(dev); +err_out_iounmap: + pcim_iounmap_regions(pdev, 1 << 1); err_out: free_netdev(dev); return rc; -- 1.7.0.4