From: Ben Hutchings <bhutchings@solarflare.com>
To: Dimitris Michailidis <dm@chelsio.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] cxgb4: exclude registers with read side effects from register dumps
Date: Sun, 11 Jul 2010 23:17:06 +0100 [thread overview]
Message-ID: <1278886626.6139.87.camel@localhost> (raw)
In-Reply-To: <1278885679-3738-6-git-send-email-dm@chelsio.com>
On Sun, 2010-07-11 at 15:01 -0700, Dimitris Michailidis wrote:
> A few registers have side effects on reads, eg FIFO pointers that
> auto advance or mailboxes which change ownership when read. They are
> unsafe to read so exclude them from ethtool register dumps.
[...]
If you change the set of registers in the dump, you need to increment
the version number.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-07-11 22:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 22:01 [PATCH net-next 0/5] cxgb4 updates Dimitris Michailidis
2010-07-11 22:01 ` [PATCH net-next 1/5] cxgb4: move the choice of interrupt type before net_device registration Dimitris Michailidis
2010-07-11 22:01 ` [PATCH net-next 2/5] cxgb4: avoid duplicating some resource freeing code Dimitris Michailidis
2010-07-11 22:01 ` [PATCH net-next 3/5] cxgb4: add user manipulation of the RSS table Dimitris Michailidis
2010-07-11 22:01 ` [PATCH net-next 4/5] cxgb4: implement the ETHTOOL_GRXFH command Dimitris Michailidis
2010-07-11 22:01 ` [PATCH net-next 5/5] cxgb4: exclude registers with read side effects from register dumps Dimitris Michailidis
2010-07-11 22:17 ` Ben Hutchings [this message]
2010-07-12 0:03 ` David Miller
2010-07-12 0:08 ` [PATCH net-next 0/5] cxgb4 updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278886626.6139.87.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).