From: James Bottomley <James.Bottomley@suse.de>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@suse.de, matthew@wil.cx, linux-scsi@vger.kernel.org
Subject: Re: [PATCH net-next] drivers/scsi: Remove warnings after vsprintf %pV introduction
Date: Mon, 12 Jul 2010 04:27:18 -0400 [thread overview]
Message-ID: <1278923239.32614.1.camel@mulgrave.site> (raw)
In-Reply-To: <20100710.231026.233698429.davem@davemloft.net>
On Sat, 2010-07-10 at 23:10 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Sat, 10 Jul 2010 22:08:41 -0700
>
> > On Sat, 2010-07-10 at 19:52 -0700, David Miller wrote:
> >> Could you take a stab at this and the other scsi bits that
> >> trigger this warning?
> >
> > Remove warnings introduced by conversions of dev_<level>
> > macros to functions.
> >
> > Compile tested only.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> SCSI folks, the background is that we have moved the dev_*() printk
> macros to external functions, so that the prefixing printf strings
> don't get emitting at every call site.
>
> As a consequence, dev_*() calls that try to use an empty string as the
> printf format emit a warning from gcc since an empty constant string
> is not a valid printf format.
>
> That's what this change is all about.
Thanks, that explains the "" -> " " conversions.
What's the other 60% of the patch about? the strange addition of
scsi_show_extd_sense_args() and all the KERN_CONT bits?
James
next prev parent reply other threads:[~2010-07-12 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 4:25 linux-next: build warning after merge of the net tree Stephen Rothwell
2010-07-08 0:45 ` David Miller
2010-07-08 1:18 ` David Miller
2010-07-08 4:13 ` Joe Perches
2010-07-11 2:52 ` David Miller
2010-07-11 5:08 ` [PATCH net-next] drivers/scsi: Remove warnings after vsprintf %pV introduction Joe Perches
2010-07-11 6:10 ` David Miller
2010-07-12 8:27 ` James Bottomley [this message]
2010-07-13 3:37 ` David Miller
2010-07-27 13:12 ` James Bottomley
2010-08-31 2:57 ` linux-next: build warning after merge of the net tree Stephen Rothwell
2010-08-31 3:14 ` Joe Perches
2010-08-31 3:58 ` Stephen Rothwell
2010-08-31 4:03 ` Joe Perches
2010-08-31 4:46 ` David Miller
2010-08-31 4:45 ` David Miller
2010-08-31 4:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278923239.32614.1.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).