From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol Date: Tue, 20 Jul 2010 19:57:13 +0100 Message-ID: <1279652233.2110.51.camel@achroite.uk.solarflarecom.com> References: <1279291156-5297-2-git-send-email-sven.eckelmann@gmx.de> <201007202023.17883.lindner_marek@yahoo.de> <201007202049.31530.sven.eckelmann@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Abraham Arce , Marek Lindner , b.a.t.m.a.n@lists.open-mesh.org, David Miller , netdev@vger.kernel.org, siwu@hrz.tu-chemnitz.de To: Sven Eckelmann Return-path: Received: from exchange.solarflare.com ([216.237.3.220]:5117 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761384Ab0GTS5R (ORCPT ); Tue, 20 Jul 2010 14:57:17 -0400 In-Reply-To: <201007202049.31530.sven.eckelmann@gmx.de> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2010-07-20 at 20:49 +0200, Sven Eckelmann wrote: > Abraham Arce wrote: > > Minor comments... > > > > 1. Is it ok to have a README in drivers directory? why not moving it > > to Documentation/networking? > > Thanks, I will check if Documentation/networking is a better place. > > > 2. Compilation error, one extra arguments passed > > > > - stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp); > > + stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp); > > > > LD kernel/built-in.o > > net/batman-adv/hard-interface.c: In function 'batman_skb_recv': > > net/batman-adv/hard-interface.c:482: error: too many arguments to > > function 'dev_get_stats' > > make[2]: *** [net/batman-adv/hard-interface.o] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [net/batman-adv] Error 2 > > make: *** [net] Error 2 > > Do you use linux-next or net-next-2.6? Because this is needed to get it > compiled as dev_get_stats was changed some time ago (commit > 28172739f0a276eb8d6ca917b3974c2edb036da3), but this is not part of 2.6.35. Even so, that cast is a bug following commit 3cfde79c6c7c8002375c4a8e5be7f602fbb9675d. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.