From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] sysfs: add entry to indicate network interfaces with random MAC address Date: Wed, 21 Jul 2010 14:54:38 +0100 Message-ID: <1279720478.2089.3.camel@achroite.uk.solarflarecom.com> References: <4C458CB7.3030508@redhat.com> <4C458F50.4070200@ixiacom.com> <4C4593DA.9040207@redhat.com> <20100720.131839.134093789.davem@davemloft.net> <4C46AB60.5060008@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: David Miller , abadea@ixiacom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gospo@redhat.com, gregory.v.rose@intel.com, alexander.h.duyck@intel.com, leedom@chelsio.com, harald@redhat.com To: Stefan Assmann Return-path: In-Reply-To: <4C46AB60.5060008@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2010-07-21 at 10:10 +0200, Stefan Assmann wrote: > On 20.07.2010 22:18, David Miller wrote: > > From: Stefan Assmann > > Date: Tue, 20 Jul 2010 14:17:30 +0200 > > > >> On 20.07.2010 13:58, Alex Badea wrote: > >>> Hi, > >>> > >>> On 07/20/2010 02:47 PM, Stefan Assmann wrote: > >>>>> What about devices that 'steal' MAC addresses from slave devices? > >>> > >>> Might I suggest an attribute such as "address_type", which could report > >>> "permanent", "random", "stolen", or something else in the future? > >> > >> In case there's demand for such a multi-purpose attribute I see no > >> reason to object. More thoughts on this? > > > > I think this is a great idea. > > > > Now it makes sense to use a new 'u8' in struct netdevice or similar to > > store this, since we'll have more than a boolean here. > > > > I put Alex' idea into code for further discussion, keeping the names > mentioned here until we agree on the scope of this attribute. When we > have settled I'll post a patch with proper patch description. [...] Just a little nitpick: I think it would be clearer to use a more specific term like 'address source' or 'address assignment type' rather than 'address type'. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.