Re: [PATCH] xt_quota: don't copy quota back to userspace

[Eric Dumazet <eric.dumazet@gmail.com>]

Le vendredi 23 juillet 2010 à 07:27 +0200, Eric Dumazet a écrit :
> Le vendredi 23 juillet 2010 à 12:54 +0800, Changli Gao a écrit :
> > This patch should be applied after my another patch:
> > http://patchwork.ozlabs.org/patch/59729/
> > 
> > xt_quota: don't copy quota back to userspace
> > 
> > In nowadays, table entries are per-cpu variables, so it don't make any sense to
> > copy quota back to one of the variable instances. To keep things simple, this
> > patch undo the copy.
> > 
> > Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> 
> This looks the wrong way to fix this problem.
> 
> Also Changli, could you please _not_ include the title of your patches
> inside the Changelog ? This is useless.
> 

Reading again your patch, I understand only the Changelog is wrong.

We want to copy quota back to userspace, as specified when rule was
setup (so that iptables-save works)

The real thing you are doing is that we dont change the initial quota
during packet processing, only the private quota, shared by all cpus.

Before the patch , iptables -nvL could report an old and not accurate
quota value.

After the patch, iptables -nvL reports the initial quota value, not the
actual value.



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html