From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: greearb@candelatech.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] pktgen: Optionally leak kernel memory
Date: Sun, 25 Jul 2010 10:27:52 +0200 [thread overview]
Message-ID: <1280046472.2451.494.camel@edumazet-laptop> (raw)
In-Reply-To: <20100724.213519.260107516.davem@davemloft.net>
Le samedi 24 juillet 2010 à 21:35 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Sat, 24 Jul 2010 16:13:15 +0200
>
> > I am not sure David will accept the patch !
>
> I don't think I can apply this, sorry :-)
Absolutely.
It might be possible for pktgen to use a pool of prebuilt pages to avoid
the cost of clearing pages. This wont work for skb without frags, unless
we change skb_release_data() (it calls kfree(skb->head), I dont think we
can trap this one...)
One better idea would be to take an extra reference on skb before giving
it to transmit, and maintain a list of skbs to recycle once their
refcount hits 1 (our reference). We could avoid most of the skb
setup/freeing costs (no more memory allocations/freeing)
I'll take a look after my vacations, unless someone motivated enough
beats me of course :)
Thanks !
prev parent reply other threads:[~2010-07-25 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 23:14 pktgen performance hit due to memset Ben Greear
2010-07-24 1:51 ` David Miller
2010-07-24 5:23 ` [PATCH net-next-2.6] pktgen: Optionally leak kernel memory Eric Dumazet
2010-07-24 13:18 ` Ben Greear
2010-07-24 14:13 ` Eric Dumazet
2010-07-24 15:35 ` Ben Greear
2010-07-25 4:35 ` David Miller
2010-07-25 8:27 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280046472.2451.494.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox