From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
uclinux-dist-devel <uclinux-dist-devel@blackfin.uclinux.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level>
Date: Tue, 27 Jul 2010 13:52:37 -0700 [thread overview]
Message-ID: <1280263957.24054.35.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100727134417.62420ec1@nehalam>
On Tue, 2010-07-27 at 13:44 -0700, Stephen Hemminger wrote:
> On Tue, 27 Jul 2010 12:22:11 -0700
> Joe Perches <joe@perches.com> wrote:
> > +static struct sk_buff *bfin_alloc_skb(void)
> > +{
> > + /* allocate a new skb */
> > + struct sk_buff *new_skb = dev_alloc_skb(PKT_BUF_SIZE + NET_IP_ALIGN);
> > +
> > + if (!new_skb)
> > + return NULL;
> > +
> > + skb_reserve(new_skb, NET_IP_ALIGN);
>
> Why not use netdev_alloc_skb_ip_align ?
I was consolidating duplicated code.
It could be changed, but right now, desc_list_init isn't
passed a struct netdevice.
Perhaps you'll submit that as a follow-on?
next prev parent reply other threads:[~2010-07-27 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 19:22 [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> Joe Perches
2010-07-27 20:44 ` Stephen Hemminger
2010-07-27 20:52 ` Joe Perches [this message]
2010-07-28 7:50 ` [Uclinux-dist-devel] " Mike Frysinger
2010-07-28 10:00 ` Joe Perches
2010-07-28 10:41 ` Hennerich, Michael
2010-07-28 15:36 ` Mike Frysinger
2010-07-29 16:24 ` Mike Frysinger
2010-07-28 13:23 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280263957.24054.35.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox