From: Joe Perches <joe@perches.com>
To: Jon Mason <jon.mason@exar.com>
Cc: Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>,
Sreenivasa Honnur <Sreenivasa.Honnur@exar.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] drivers/net/vxge: Use pr_<level>, fix logging macros
Date: Tue, 27 Jul 2010 14:43:35 -0700 [thread overview]
Message-ID: <1280267015.24054.42.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100727213819.GC25556@exar.com>
On Tue, 2010-07-27 at 16:38 -0500, Jon Mason wrote:
> On Tue, Jul 27, 2010 at 01:43:08PM -0700, Joe Perches wrote:
> > Use direct printing of logging messages to save text.
> I have a similar patch queued internally (pending testing).
Great.
[]
> Why not make the entire vxge_debug part of vxge_debug_ll? If
> disabled, that code can be removed completely as it is unnecessary.
> Also, why not call printk directly from vxge_debug? This code had too
> many levels of indirection before, remove all of them (as that is way
> I did in the internal patch).
'cause I don't really want to figure out the nesting,
I just want it to be smaller and easier to understand.
> I did not have any of these changes in my patch. If you want to push
> this seperately, I ack it.
I'll resend separately.
cheers, Joe
prev parent reply other threads:[~2010-07-27 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 20:43 [PATCH net-next] drivers/net/vxge: Use pr_<level>, fix logging macros Joe Perches
2010-07-27 21:38 ` Jon Mason
2010-07-27 21:43 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280267015.24054.42.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=davem@davemloft.net \
--cc=jon.mason@exar.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).