From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_ Date: Wed, 28 Jul 2010 03:00:40 -0700 Message-ID: <1280311240.24054.103.camel@Joe-Laptop.home> References: <1280258531.24054.10.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Michael Hennerich , uclinux-dist-devel , LKML , netdev To: Mike Frysinger Return-path: Received: from mail.perches.com ([173.55.12.10]:2152 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569Ab0G1KAm (ORCPT ); Wed, 28 Jul 2010 06:00:42 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote: > On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote: > > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" > > total: 2 errors, 25 warnings, 1723 lines checked > > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" > > total: 0 errors, 0 warnings, 1743 lines checked > i dislike the mixing of whitespace and useful changes > if they were split, and they worked, then i wouldnt have a problem with them Is that a nak or a dislike? Also, is Michael Hennerich actually the maintainer for bfin_mac? He had been listed as MAINTAINER for over a year but he hasn't ever written or acked a patch for this file. commit making Michael Hennerich bfin_mac MAINTAINER $ git log -1 6c83429a commit 6c83429a1c32c914dfb81939cc2ddece97e48294 Author: Mike Frysinger Date: Sun May 24 02:13:15 2009 -0400 MAINTAINERS: update Blackfin items With Bryan Wu having moved on to another job, push the slack onto some other ADI lackeys. Signed-off-by: Mike Frysinger $ ./scripts/get_maintainer.pl -f drivers/net/bfin_mac.c \ --rolestats --git-since=5-years-ago --nol Michael Hennerich (supporter:BLACKFIN EMAC DRIVER) "David S. Miller" (commit_signer:41/65=63%) Jeff Garzik (commit_signer:31/65=48%) Bryan Wu (commit_signer:26/65=40%) Mike Frysinger (commit_signer:20/65=31%) Sonic Zhang (commit_signer:8/65=12%)