From: Johannes Berg <johannes@sipsolutions.net>
To: netdev <netdev@vger.kernel.org>
Subject: Re: RPS vs. hard-irq-context netif_rx()
Date: Fri, 30 Jul 2010 15:21:55 +0200 [thread overview]
Message-ID: <1280496115.3710.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1280495027.3710.13.camel@jlt3.sipsolutions.net>
On Fri, 2010-07-30 at 15:03 +0200, Johannes Berg wrote:
> The reason seems to be that
> * RCU_TREE uses local_bh_disable/enable
> * CONFIG_RPS uses RCU within netif_rx()
> * the driver I'm using calls netif_rx() within the irq context
>
> So .. where's the bug? I'd point to CONFIG_RPS since it's newest.
Disabling RPS gives me the same result due to netpoll since
commit de85d99eb7b595f6751550184b94c1e2f74a828b
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu Jun 10 16:12:44 2010 +0000
netpoll: Fix RCU usage
Disabling netpoll as well gets me a warning-free boot, but I suspect
that's not really what it should be like...
johannes
next prev parent reply other threads:[~2010-07-30 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 13:03 RPS vs. hard-irq-context netif_rx() Johannes Berg
2010-07-30 13:21 ` Johannes Berg [this message]
2010-08-17 11:52 ` Luca Tettamanti
2010-08-17 14:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280496115.3710.20.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).