* [PATCH] davinci_emac: Fix use after free in davinci_emac_remove
@ 2010-08-03 18:53 Stefan Weil
2010-08-04 4:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2010-08-03 18:53 UTC (permalink / raw)
To: netdev
Cc: Stefan Weil, David S. Miller, Chaithrika U S, Sriramakrishnan,
Kevin Hilman, linux-kernel
free_netdev finally calls kfree which makes the contents
of ndev and priv (private data contained in ndev) invalid.
So iounmap should be called before free_netdev.
Cc: David S. Miller <davem@davemloft.net>
Cc: Chaithrika U S <chaithrika@ti.com>
Cc: Sriramakrishnan <srk@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
drivers/net/davinci_emac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 8cc8a43..866e6b8 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -2818,8 +2818,8 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev)
release_mem_region(res->start, res->end - res->start + 1);
unregister_netdev(ndev);
- free_netdev(ndev);
iounmap(priv->remap_addr);
+ free_netdev(ndev);
clk_disable(emac_clk);
clk_put(emac_clk);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] davinci_emac: Fix use after free in davinci_emac_remove
2010-08-03 18:53 [PATCH] davinci_emac: Fix use after free in davinci_emac_remove Stefan Weil
@ 2010-08-04 4:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-04 4:36 UTC (permalink / raw)
To: weil; +Cc: netdev, chaithrika, srk, khilman, linux-kernel
From: Stefan Weil <weil@mail.berlios.de>
Date: Tue, 3 Aug 2010 20:53:45 +0200
> free_netdev finally calls kfree which makes the contents
> of ndev and priv (private data contained in ndev) invalid.
>
> So iounmap should be called before free_netdev.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Chaithrika U S <chaithrika@ti.com>
> Cc: Sriramakrishnan <srk@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
I'll apply this, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-04 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 18:53 [PATCH] davinci_emac: Fix use after free in davinci_emac_remove Stefan Weil
2010-08-04 4:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).