public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: Ursula Braun1 <ursula.braun@de.ibm.com>
Cc: blaschka@linux.vnet.ibm.com, linux-s390@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Fw: [PATCH net-next] drivers/s390/net/qeth_l3_main.c: Use %pI6
Date: Thu, 12 Aug 2010 18:36:00 +0200	[thread overview]
Message-ID: <1281630960.12375.8.camel@braunu-laptop> (raw)
In-Reply-To: <OF89C50871.5ED34E2A-ONC125777D.005A40DE-C125777D.005A4DDE@de.ibm.com>

ACK
Thanks Joe - we make sure your patch is submitted to Dave Miller within
our next submission of qeth patches.

Ursula

> From:     Joe Perches <joe@perches.com>
> To:       Frank Blaschka <blaschka@linux.vnet.ibm.com>
> Subject:  [PATCH net-next] drivers/s390/net/qeth_l3_main.c: Use %pI6

> Format an ipv6 address using vsprintf extensions.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/s390/net/qeth_l3_main.c |    7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/s390/net/qeth_l3_main.c
> b/drivers/s390/net/qeth_l3_main.c
> index e22ae24..561bdc8 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -103,12 +103,7 @@ int qeth_l3_string_to_ipaddr4(const char *buf,
> __u8 *addr)
> 
> void qeth_l3_ipaddr6_to_string(const __u8 *addr, char *buf)
> {
> -                 sprintf(buf, "%02x%02x:%02x%02x:%02x%02x:%02x%02x"
> -                                       ":%02x%02x:%02x%02x:%02x%02x:%
> 02x%02x",
> -                                       addr[0], addr[1], addr[2],
> addr[3],
> -                                       addr[4], addr[5], addr[6],
> addr[7],
> -                                       addr[8], addr[9], addr[10],
> addr[11],
> -                                       addr[12], addr[13], addr[14],
> addr[15]);
> +                 sprintf(buf, "%pI6", addr);
> }
> 
> int qeth_l3_string_to_ipaddr6(const char *buf, __u8 *addr)
> 
> 

           reply	other threads:[~2010-08-12 16:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <OF89C50871.5ED34E2A-ONC125777D.005A40DE-C125777D.005A4DDE@de.ibm.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281630960.12375.8.camel@braunu-laptop \
    --to=ubraun@linux.vnet.ibm.com \
    --cc=blaschka@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ursula.braun@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox