From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] netlink: netlink_recvmsg() fix
Date: Fri, 13 Aug 2010 16:00:24 +0200 [thread overview]
Message-ID: <1281708024.3760.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100725.215548.112589000.davem@davemloft.net>
On Sun, 2010-07-25 at 21:55 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 21 Jul 2010 10:43:55 +0200
>
> > [PATCH net-next-2.6 v3] netlink: netlink_recvmsg() fix
> >
> > commit 1dacc76d0014
> > (net/compat/wext: send different messages to compat tasks)
> > introduced a race condition on netlink, in case MSG_PEEK is used.
> >
> > An skb given by skb_recv_datagram() might be shared, we must copy it
> > before any modification, or risk fatal corruption.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Applied, thanks Eric.
I keep getting errors like below in 2.6.35+wireless-testing. Not saying
that it's this patch's fault, but it is the only thing I remember
touching that area.
[10548.768754] =============================================================================
[10548.773474] BUG kmalloc-4096: Object already free
[10548.775342] -----------------------------------------------------------------------------
[10548.775344]
[10548.778505] INFO: Allocated in wireless_send_event+0x1f2/0x410 age=1 cpu=0 pid=28521
[10548.778505] INFO: Freed in skb_release_data+0xd0/0xe0 age=2 cpu=2 pid=27730
[10548.778505] INFO: Slab 0xffffea0003fa4b80 objects=7 used=1 fp=0xffff880122f12090 flags=0x80000000000040c3
[10548.778505] INFO: Object 0xffff880122f12090 @offset=8336 fp=0xffff880122f11048
[10548.778505]
[10548.778505] Bytes b4 0xffff880122f12080: 6c a3 0f 00 01 00 00 00 5a 5a 5a 5a 5a 5a 5a 5a l�......ZZZZZZZZ
...
[10548.778505] Object 0xffff880122f13080: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 kkkkkkkkkkkkkkk�
[10548.778505] Redzone 0xffff880122f13090: bb bb bb bb bb bb bb bb ��������
[10548.778505] Padding 0xffff880122f130d0: 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ
[10548.778505] Pid: 916, comm: avahi-daemon Tainted: G W 2.6.35-wl-67184-g1595c70-dirty #12
[10548.778505] Call Trace:
[10548.778505] [<ffffffff81133993>] print_trailer+0x103/0x160
[10548.778505] [<ffffffff81133a31>] object_err+0x41/0x50
[10548.778505] [<ffffffff81135b0f>] __slab_free+0x24f/0x3b0
[10548.778505] [<ffffffff81135da2>] kfree+0x132/0x1a0
[10548.778505] [<ffffffff81383710>] skb_release_data+0xd0/0xe0
[10548.778505] [<ffffffff813831be>] __kfree_skb+0x1e/0xa0
[10548.778505] [<ffffffff813832c2>] kfree_skb+0x42/0xb0
[10548.778505] [<ffffffff813ac3f2>] netlink_recvmsg+0x422/0x480
[10548.778505] [<ffffffff8137afdd>] sock_recvmsg+0xfd/0x130
[10548.778505] [<ffffffff8137c1e4>] __sys_recvmsg+0x144/0x2e0
[10548.778505] [<ffffffff8137c629>] sys_recvmsg+0x49/0x80
[10548.778505] [<ffffffff8100b132>] system_call_fastpath+0x16/0x1b
[10548.778505] FIX kmalloc-4096: Object at 0xffff880122f12090 not freed
johannes
next prev parent reply other threads:[~2010-08-13 14:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 13:16 [PATCH net-next-2.6] netlink: netlink_recvmsg() fix Eric Dumazet
2010-07-20 15:20 ` Eric Dumazet
2010-07-21 8:05 ` Johannes Berg
2010-07-21 8:20 ` Eric Dumazet
2010-07-21 8:43 ` Eric Dumazet
2010-07-26 4:55 ` David Miller
2010-07-26 20:08 ` David Miller
2010-07-26 20:39 ` Eric Dumazet
2010-07-26 20:48 ` David Miller
2010-07-26 20:55 ` Eric Dumazet
2010-08-13 14:00 ` Johannes Berg [this message]
2010-08-13 14:35 ` Johannes Berg
2010-08-13 14:48 ` Eric Dumazet
2010-08-13 15:13 ` Johannes Berg
2010-08-15 5:37 ` David Miller
2010-08-16 5:25 ` Johannes Berg
2010-08-16 6:10 ` Eric Dumazet
2010-08-16 6:21 ` David Miller
2010-08-16 6:22 ` Johannes Berg
2010-08-16 6:29 ` Eric Dumazet
2010-08-16 6:31 ` Johannes Berg
2010-08-16 7:20 ` [PATCH] netlink: fix compat recvmsg Johannes Berg
2010-08-16 12:50 ` Eric Dumazet
2010-08-16 12:54 ` Johannes Berg
2010-08-16 13:01 ` Eric Dumazet
2010-08-19 6:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281708024.3760.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).