From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Kalle Valo <kalle.valo@iki.fi>
Subject: Re: [PATCH] netlink: fix compat recvmsg
Date: Mon, 16 Aug 2010 14:54:39 +0200 [thread overview]
Message-ID: <1281963279.3683.16.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1281963025.2524.43.camel@edumazet-laptop>
On Mon, 2010-08-16 at 14:50 +0200, Eric Dumazet wrote:
> > Additionally, while preparing this patch I found
> > that since none of the remaining netlink code is
> > really aware of the frag_list, we need to use the
> > original skb's information for packet information
> > and credentials. This fixes, for example, the
> > group information received by compat tasks.
> As a side effect, it might fix the
>
> if (nlk->flags & NETLINK_RECV_PKTINFO)
> netlink_cmsg_recv_pktinfo(msg, skb);
>
> That tried to use pktinfo from the slave skb. After this
> patch, skb points to master skb.
Yeah, that's what I was looking at regarding the "packet information" I
wrote about. The group information was wrong (0 rather than 1), I could
see that in strace (though I had to compile a strace64 binary first...)
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Thanks !
Thanks for looking, and finding the bug to start with :-)
johannes
next prev parent reply other threads:[~2010-08-16 12:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 13:16 [PATCH net-next-2.6] netlink: netlink_recvmsg() fix Eric Dumazet
2010-07-20 15:20 ` Eric Dumazet
2010-07-21 8:05 ` Johannes Berg
2010-07-21 8:20 ` Eric Dumazet
2010-07-21 8:43 ` Eric Dumazet
2010-07-26 4:55 ` David Miller
2010-07-26 20:08 ` David Miller
2010-07-26 20:39 ` Eric Dumazet
2010-07-26 20:48 ` David Miller
2010-07-26 20:55 ` Eric Dumazet
2010-08-13 14:00 ` Johannes Berg
2010-08-13 14:35 ` Johannes Berg
2010-08-13 14:48 ` Eric Dumazet
2010-08-13 15:13 ` Johannes Berg
2010-08-15 5:37 ` David Miller
2010-08-16 5:25 ` Johannes Berg
2010-08-16 6:10 ` Eric Dumazet
2010-08-16 6:21 ` David Miller
2010-08-16 6:22 ` Johannes Berg
2010-08-16 6:29 ` Eric Dumazet
2010-08-16 6:31 ` Johannes Berg
2010-08-16 7:20 ` [PATCH] netlink: fix compat recvmsg Johannes Berg
2010-08-16 12:50 ` Eric Dumazet
2010-08-16 12:54 ` Johannes Berg [this message]
2010-08-16 13:01 ` Eric Dumazet
2010-08-19 6:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281963279.3683.16.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kalle.valo@iki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).