From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: don't disable BH again in BH disabled context
Date: Tue, 17 Aug 2010 08:55:27 +0200 [thread overview]
Message-ID: <1282028127.2487.754.camel@edumazet-laptop> (raw)
In-Reply-To: <1282027297-9998-1-git-send-email-xiaosuo@gmail.com>
Le mardi 17 août 2010 à 14:41 +0800, Changli Gao a écrit :
> All the matches and targets of iptables, ip6tables are in BH disabled
> context, since xt_info_rdlock_bh() disables BH.
>
Its a thing that might change in a future version. Not a hard fact.
You can probably change iptables to allow softirqs while processing
OUTPUT chains.
We had some attempts in the past to switch to RCU.
It failed at that time because of some RCU implementation details, but
with recent RCU changes, we might try again, and have a clean
implementation, allowing softirqs.
So your patch would need to be reverted.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-17 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 6:41 [PATCH] netfilter: don't disable BH again in BH disabled context Changli Gao
2010-08-17 6:55 ` Eric Dumazet [this message]
2010-09-22 10:20 ` Changli Gao
2010-09-22 13:22 ` Eric Dumazet
2010-08-17 8:29 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282028127.2487.754.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox