Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	ameen.rahman@qlogic.com,
	Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Subject: Re: [PATCHv3 NEXT 7/7] qlcnic: turn off lro when rxcsum is disabled.
Date: Tue, 17 Aug 2010 07:48:52 -0700	[thread overview]
Message-ID: <1282056532.24541.89.camel@Joe-Laptop> (raw)
In-Reply-To: <1282041265-32591-8-git-send-email-amit.salecha@qlogic.com>

On Tue, 2010-08-17 at 03:34 -0700, Amit Kumar Salecha wrote:
> From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>

Thanks all, 2 minor comments below.

> --- a/drivers/net/qlcnic/qlcnic_ethtool.c
> +++ b/drivers/net/qlcnic/qlcnic_ethtool.c
> @@ -818,7 +818,21 @@ static u32 qlcnic_get_rx_csum(struct net_device *dev)
>  static int qlcnic_set_rx_csum(struct net_device *dev, u32 data)
[]
> 	dev_info(&adapter->pdev->dev, "disabling LRO as rx_csum is off\n");

I think netdev_<level> should be used when a
struct net_device * is available.

	netdev_info(dev, "disabling LRO as rx_csum is off\n");

> @@ -1001,6 +1015,15 @@ static int qlcnic_set_flags(struct net_device *netdev, u32 data)
[]
> +	if (!adapter->rx_csum) {
> +		dev_info(&adapter->pdev->dev, "rx csum is off, "
> +			"cannot toggle lro\n");

		netdev_info(netdev, "rx csum is off, cannot toggle LRO\n");

and please use consistent acronym case.


  reply	other threads:[~2010-08-17 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17 10:34 [PATCH NEXTv3 0/3]qlcnic: enhancement and fixes Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 1/7] qlcnic: fix aer for virtual func Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 2/7] qlcnic: device state management fixes " Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 3/7] qlcnic: fix for setting function modes Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 4/7] qlcnic: add eswitch statistics support Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 5/7] qlcnic: fix link status message Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 6/7] qlcnic: fix link diag test Amit Kumar Salecha
2010-08-17 10:34 ` [PATCHv3 NEXT 7/7] qlcnic: turn off lro when rxcsum is disabled Amit Kumar Salecha
2010-08-17 14:48   ` Joe Perches [this message]
2010-08-18  6:39     ` Amit Salecha
2010-08-17 11:00 ` [PATCH NEXTv3 0/3]qlcnic: enhancement and fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282056532.24541.89.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=ameen.rahman@qlogic.com \
    --cc=amit.salecha@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sucheta.chakraborty@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox