From: Eric Dumazet <eric.dumazet@gmail.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: netdev@vger.kernel.org, Johannes Berg <johannes@sipsolutions.net>
Subject: Re: RPS vs. hard-irq-context netif_rx()
Date: Tue, 17 Aug 2010 16:54:37 +0200 [thread overview]
Message-ID: <1282056877.2448.59.camel@edumazet-laptop> (raw)
In-Reply-To: <20100817115230.GA6510@nb-core2.darkstar.lan>
Le mardi 17 août 2010 à 13:52 +0200, Luca Tettamanti a écrit :
> > I got the following on a kvm instance I use for testing:
> >
> > [ 51.358803] WARNING: at kernel/lockdep.c:2327trace_hardirqs_on_caller+0x167/0x200()
> > [ 51.360210] Hardware name: Bochs
> > [ 51.360210] Modules linked in:
> > [ 51.360210] Pid: 1546, comm: dhclient3 Tainted: G W 2.6.35-rc6-wl+ #588
> > [ 51.360210] Call Trace:
> > [ 51.360210] <IRQ> [<ffffffff8104e87f>] warn_slowpath_common+0x7f/0xc0
> > [ 51.360210] [<ffffffff8104e8da>] warn_slowpath_null+0x1a/0x20
> > [ 51.360210] [<ffffffff81087977>] trace_hardirqs_on_caller+0x167/0x200
> > [ 51.360210] [<ffffffff81087a1d>] trace_hardirqs_on+0xd/0x10
> > [ 51.360210] [<ffffffff81056ade>] local_bh_enable+0x9e/0x130
> > [ 51.360210] [<ffffffff8139fa82>] netif_rx+0xc2/0x250
> > [ 51.360210] [<ffffffff813146d7>] ei_receive+0x1b7/0x2c0
> > [ 51.360210] [<ffffffff81314ca2>] __ei_interrupt+0x282/0x360
> > [ 51.360210] [<ffffffff81314dce>] ei_interrupt+0xe/0x10
> > [ 51.360210] [<ffffffff810abe85>] handle_IRQ_event+0x85/0x300
> > [ 51.360210] [<ffffffff810aead5>] handle_level_irq+0x95/0x120
> > [ 51.360210] [<ffffffff81005a12>] handle_irq+0x22/0x30
> > [ 51.360210] [<ffffffff814394b3>] do_IRQ+0x73/0xf0
> [...]
> >So .. where's the bug? I'd point to CONFIG_RPS since it's newest.
>
> Hello,
> I just hit the same warning, with 2.6.36-rc1:
>
> [ 228.001459] WARNING: at /home/kronos/src/linux-2.6.git/kernel/softirq.c:143 local_bh_enable+0x3c/0x9a()
> [ 228.004096] Hardware name: F3Sa
> [ 228.004175] Modules linked in: [...]
> [ 228.015974] Pid: 2818, comm: irqbalance Not tainted 2.6.36-rc1 #274
> [ 228.015974] Call Trace:
> [ 228.015974] <IRQ> [<ffffffff81034b32>] warn_slowpath_common+0x80/0x98
> [ 228.015974] [<ffffffff81034b5f>] warn_slowpath_null+0x15/0x17
> [ 228.015974] [<ffffffff8103a009>] local_bh_enable+0x3c/0x9a
> [ 228.015974] [<ffffffff8120dc16>] netif_rx+0x75/0x145
> [ 228.015974] [<ffffffff8115162f>] ? unmap_single+0x4a/0x52
> [ 228.015974] [<ffffffff811e7fcd>] atl1_intr+0x96c/0xa35
> [ 228.015974] [<ffffffff8104edf4>] ? hrtimer_wakeup+0x0/0x21
> [ 228.015974] [<ffffffff810707b2>] handle_IRQ_event+0x20/0x9a
> [ 228.015974] [<ffffffff810723ba>] handle_edge_irq+0xf5/0x141
> [ 228.015974] [<ffffffff81004d53>] handle_irq+0x83/0x8c
> [ 228.015974] [<ffffffff81004332>] do_IRQ+0x5e/0xc4
> [ 228.015974] [<ffffffff812843d3>] ret_from_intr+0x0/0xa
>
> CONFIG_TREE_RCU=y
> CONFIG_RPS=y
>
> I never saw the warning with 2.6.35 and earlier kernels though.
This is a known problem, related to netpoll
http://www.kerneltrap.com/mailarchive/linux-netdev/2010/8/10/6282780
prev parent reply other threads:[~2010-08-17 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 13:03 RPS vs. hard-irq-context netif_rx() Johannes Berg
2010-07-30 13:21 ` Johannes Berg
2010-08-17 11:52 ` Luca Tettamanti
2010-08-17 14:54 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282056877.2448.59.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kronos.it@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox