Re: [PATCH v2] net/sched: add ACT_CSUM action to update packets checksums

[jamal <hadi@cyberus.ca>]

On Wed, 2010-08-18 at 01:59 +0200, Grégoire Baron wrote:


> +static int tcf_csum_ipv4_icmp(struct sk_buff *skb,
> +			      unsigned int ihl, unsigned int ipl)
> +{
> +	struct icmphdr *icmph;
> +
> +	icmph = tcf_csum_skb_nextlayer(skb, ihl, ipl, sizeof(*icmph));
> +	if (icmph == NULL)
> +		goto fail;
                  ^^^^^^^^^^^
> +	icmph->checksum = 0;
> +	skb->csum = csum_partial(icmph, ipl - ihl, 0);
> +	icmph->checksum = csum_fold(skb->csum);
> +
> +	skb->ip_summed = CHECKSUM_NONE;
> +
> +	return 1;
> +
> +fail:
> +	return 0;
> +}
> +

I think you missed one of my earlier comments:
Do you really need this goto? You should just "return 0" instead of
"goto fail"
Same with many other similar places where the "fail:" just simply
returns 0 such as igmp, ipv6_icmp, ipv4_udp, etc

BTW, i still think there may be a clever way to unify things - but we
can leave that for another day;-> If you fix the above please add
my Acked-by.

cheers,
jamal