From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: brking@linux.vnet.ibm.com, ossthema@de.ibm.com,
osstklei@de.ibm.com, raisch@de.ibm.com, netdev@vger.kernel.org,
Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL
Date: Wed, 18 Aug 2010 16:10:52 +0200 [thread overview]
Message-ID: <1282140652.2194.90.camel@edumazet-laptop> (raw)
In-Reply-To: <20100701.224805.221588889.davem@davemloft.net>
Le jeudi 01 juillet 2010 à 22:48 -0700, David Miller a écrit :
> From: Brian King <brking@linux.vnet.ibm.com>
> Date: Wed, 30 Jun 2010 16:59:12 -0500
>
> >
> > Since ehea_get_stats calls ehea_h_query_ehea_port, which
> > can sleep, we can also sleep when allocating a page in
> > this function. This fixes some memory allocation failure
> > warnings seen under low memory conditions.
> >
> > Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>
> Applied to net-next-2.6
> --
I believe there is a problem with this patch and/or bonding.
If we say ndo_get_stats() methods are allowed to sleep, then
bond_get_stats() should be updated, because it currently calls
dev_get_stats() from a read_lock_bh(&bond->lock); section.
Are we allowed to sleep inside a read_lock_bh() ?
next prev parent reply other threads:[~2010-08-18 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 21:59 [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL Brian King
2010-07-02 5:48 ` David Miller
2010-08-18 14:10 ` Eric Dumazet [this message]
2010-08-18 17:49 ` Jay Vosburgh
2010-08-19 7:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282140652.2194.90.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox