Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jon Mason <jon.mason@exar.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>,
	Sivakumar Subramani <Sivakumar.Subramani@exar.com>,
	Sreenivasa Honnur <Sreenivasa.Honnur@exar.com>
Subject: Re: [PATCH net-next-2.6] vxge: Implement 64bit stats
Date: Wed, 18 Aug 2010 17:28:43 +0200	[thread overview]
Message-ID: <1282145323.2194.105.camel@edumazet-laptop> (raw)
In-Reply-To: <20100818152531.GB9202@exar.com>

Le mercredi 18 août 2010 à 10:25 -0500, Jon Mason a écrit :
> On Wed, Aug 18, 2010 at 06:42:54AM -0700, Eric Dumazet wrote:
> > vxge_get_stats() is racy, since it clears a block of memory (net_stats)
> > possibly still used by other cpus.
> > 
> > We can update this driver to full 64bit stats, since ndo_get_stats64()
> > provides a private block to store results, and driver maintains 64bit
> > counters already.
> > 
> > We also remove net_stats field from struct vxge_sw_stats
> 
> It looks sane.  Assuming you have not tested it already, I'll give it a
> quick sanity check.

I did not test it, I would be grateful if you can do this ;)

Thanks



  reply	other threads:[~2010-08-18 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 13:42 [PATCH net-next-2.6] vxge: Implement 64bit stats Eric Dumazet
2010-08-18 15:25 ` Jon Mason
2010-08-18 15:28   ` Eric Dumazet [this message]
2010-08-18 22:53 ` Jon Mason
2010-08-19  7:17   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282145323.2194.105.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=Ramkrishna.Vepa@exar.com \
    --cc=Sivakumar.Subramani@exar.com \
    --cc=Sreenivasa.Honnur@exar.com \
    --cc=davem@davemloft.net \
    --cc=jon.mason@exar.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox