netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC patch] include/net/cfg80211.h: wiphy_<level> messages use dev_printk
Date: Thu, 19 Aug 2010 21:39:44 +0200	[thread overview]
Message-ID: <1282246784.4507.14.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1282245848.6724.261.camel@Joe-Laptop>

On Thu, 2010-08-19 at 12:24 -0700, Joe Perches wrote:
> Adding device to the wiphy logging messages could be useful.
>  
>  #define wiphy_printk(level, wiphy, format, args...)		\
> -	printk(level "%s: " format, wiphy_name(wiphy), ##args)
> +	dev_printk(level, &wiphy->dev, "%s: " format, wiphy_name(wiphy), ##args)

what will that actually print?

johannes

  reply	other threads:[~2010-08-19 19:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 19:24 [RFC patch] include/net/cfg80211.h: wiphy_<level> messages use dev_printk Joe Perches
2010-08-19 19:39 ` Johannes Berg [this message]
2010-08-20 22:13   ` [RFC patch (against wireless-next)] " Joe Perches
2010-08-25 18:01     ` John W. Linville
2010-08-25 18:25       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282246784.4507.14.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).