From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev Date: Fri, 20 Aug 2010 12:26:12 +0200 Message-ID: <1282299972.2484.21.camel@edumazet-laptop> References: <20100819152143.8a57c465.akpm@linux-foundation.org> <4C6E0C99.2060407@fs.uni-ruse.bg> <20100819221142.b8f6a70a.akpm@linux-foundation.org> <4C6E1CBA.2060605@fs.uni-ruse.bg> <20100819232019.6f6074a8.akpm@linux-foundation.org> <4C6E202E.5030406@fs.uni-ruse.bg> <1282286070.2295.6.camel@edumazet-laptop> <4C6E3D58.5080303@fs.uni-ruse.bg> <4C6E488A.4010100@fs.uni-ruse.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org To: Plamen Petrov Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:42110 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab0HTK0R (ORCPT ); Fri, 20 Aug 2010 06:26:17 -0400 Received: by wwi17 with SMTP id 17so3873268wwi.1 for ; Fri, 20 Aug 2010 03:26:16 -0700 (PDT) In-Reply-To: <4C6E488A.4010100@fs.uni-ruse.bg> Sender: netdev-owner@vger.kernel.org List-ID: Le vendredi 20 ao=C3=BBt 2010 =C3=A0 12:19 +0300, Plamen Petrov a =C3=A9= crit : > =D0=9D=D0=B0 20.8.2010 =D0=B3. 11:31, Plamen Petrov =D0=BD=D0=B0=D0=BF= =D0=B8=D1=81=D0=B0: > ... > > The next thing I will be trying is disabling > > GRO for the tg3 network card in my network > > startup scripts via my shiny new ethtool... ;) >=20 > So, for nearly half an hour now running 2.6.36-rc1-FS-00127-g763008c: >=20 > > > root@fs:~# w; uname -a > > 12:09:48 up 26 min, 1 user, load average: 2.43, 1.93, 1.26 > > USER TTY FROM LOGIN@ IDLE JCPU PCPU WHA= T > > root pts/0 192.168.10.159 12:09 0.00s 0.02s 0.00s w > > Linux fs 2.6.36-rc1-FS-00127-g763008c #1 SMP Thu Aug 19 07:10:57 UT= C 2010 i686 Intel(R) Pentium(R) D CPU 3.00GHz GenuineIntel GNU/Linux >=20 > And that's with the usual load, which can be found here: > http://pvp.now.im/s/drraw.cgi?Mode=3Dview;Dashboard=3D1173713287.1317= 7 >=20 > The only addition I made was running > ethtool -K ethX gro off > for each network card. >=20 > Which means that I have a Broadcom Tygon 3 (tg3) which doesn't > like "generic-receive-offload" at all! >=20 > With "generic-receive-offload" off, I will stay on > 2.6.36-rc1-FS-00127-g763008c for as long as I can, just to > confirm that in fact the "default on" setting for gro in the > tg3 driver is the culprit for my troubles... >=20 > Where to next? =46irst, thanks a lot for finding this so fast. Hmmm, please check that on your net/core/dev.c file, line 3146 you have the fix added in=20 http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3D= commitdiff;h=3De5093aec2e6b60c3df2420057ffab9ed4a6d2792 commit e5093aec2e6b60c3df2420057ffab9ed4a6d2792 Author: Jarek Poplawski Date: Wed Aug 11 02:02:10 2010 +0000 net: Fix a memmove bug in dev_gro_receive() =20 --skb_shinfo(skb)->nr_frags * sizeof(skb_frag_t)); If yes, I think David & Herbert will probably have to dig again into gr= o code :(