* [PATCH] net_sched: cls_flow: add key rxhash
@ 2010-08-21 16:23 Changli Gao
2010-08-21 21:41 ` jamal
0 siblings, 1 reply; 3+ messages in thread
From: Changli Gao @ 2010-08-21 16:23 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David S. Miller, netdev, Changli Gao
We can use rxhash to classify the traffic into flows. As rxhash maybe
supplied by NIC or RPS, it is cheaper.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
include/linux/pkt_cls.h | 1 +
net/sched/cls_flow.c | 7 +++++++
2 files changed, 8 insertions(+)
diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h
index 7f6ba86..defbde2 100644
--- a/include/linux/pkt_cls.h
+++ b/include/linux/pkt_cls.h
@@ -332,6 +332,7 @@ enum {
FLOW_KEY_SKUID,
FLOW_KEY_SKGID,
FLOW_KEY_VLAN_TAG,
+ FLOW_KEY_RXHASH,
__FLOW_KEY_MAX,
};
diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c
index cd709f1..5b271a1 100644
--- a/net/sched/cls_flow.c
+++ b/net/sched/cls_flow.c
@@ -306,6 +306,11 @@ static u32 flow_get_vlan_tag(const struct sk_buff *skb)
return tag & VLAN_VID_MASK;
}
+static u32 flow_get_rxhash(struct sk_buff *skb)
+{
+ return skb_get_rxhash(skb);
+}
+
static u32 flow_key_get(struct sk_buff *skb, int key)
{
switch (key) {
@@ -343,6 +348,8 @@ static u32 flow_key_get(struct sk_buff *skb, int key)
return flow_get_skgid(skb);
case FLOW_KEY_VLAN_TAG:
return flow_get_vlan_tag(skb);
+ case FLOW_KEY_RXHASH:
+ return flow_get_rxhash(skb);
default:
WARN_ON(1);
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net_sched: cls_flow: add key rxhash
2010-08-21 16:23 [PATCH] net_sched: cls_flow: add key rxhash Changli Gao
@ 2010-08-21 21:41 ` jamal
2010-08-22 6:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: jamal @ 2010-08-21 21:41 UTC (permalink / raw)
To: Changli Gao; +Cc: David S. Miller, netdev
On Sun, 2010-08-22 at 00:23 +0800, Changli Gao wrote:
> We can use rxhash to classify the traffic into flows. As rxhash maybe
> supplied by NIC or RPS, it is cheaper.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Nice idea.
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net_sched: cls_flow: add key rxhash
2010-08-21 21:41 ` jamal
@ 2010-08-22 6:41 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-08-22 6:41 UTC (permalink / raw)
To: hadi; +Cc: xiaosuo, netdev
From: jamal <hadi@cyberus.ca>
Date: Sat, 21 Aug 2010 17:41:32 -0400
> On Sun, 2010-08-22 at 00:23 +0800, Changli Gao wrote:
>> We can use rxhash to classify the traffic into flows. As rxhash maybe
>> supplied by NIC or RPS, it is cheaper.
>>
>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>
> Nice idea.
> Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Sometimes the simplest patches are the best :-)
Applied, thanks Changli!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-22 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-21 16:23 [PATCH] net_sched: cls_flow: add key rxhash Changli Gao
2010-08-21 21:41 ` jamal
2010-08-22 6:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).