* [PATCH] iproute2: tc: f_flow: add key rxhash
@ 2010-08-21 16:30 Changli Gao
2010-08-21 21:42 ` jamal
0 siblings, 1 reply; 3+ messages in thread
From: Changli Gao @ 2010-08-21 16:30 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jamal Hadi Salim, netdev, Changli Gao
We can use rxhash to classify the traffic into flows. As rxhash maybe
supplied by NIC or RPS, it is cheaper.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
include/linux/pkt_cls.h | 1 +
tc/f_flow.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h
index 7f6ba86..defbde2 100644
--- a/include/linux/pkt_cls.h
+++ b/include/linux/pkt_cls.h
@@ -332,6 +332,7 @@ enum {
FLOW_KEY_SKUID,
FLOW_KEY_SKGID,
FLOW_KEY_VLAN_TAG,
+ FLOW_KEY_RXHASH,
__FLOW_KEY_MAX,
};
diff --git a/tc/f_flow.c b/tc/f_flow.c
index 84b45c9..574253d 100644
--- a/tc/f_flow.c
+++ b/tc/f_flow.c
@@ -33,7 +33,7 @@ static void explain(void)
"KEY := [ src | dst | proto | proto-src | proto-dst | iif | priority | \n"
" mark | nfct | nfct-src | nfct-dst | nfct-proto-src | \n"
" nfct-proto-dst | rt-classid | sk-uid | sk-gid |\n"
-" vlan-tag ]\n"
+" vlan-tag | rxhash ]\n"
"OPS := [ or NUM | and NUM | xor NUM | rshift NUM | addend NUM ]\n"
"ID := X:Y\n"
);
@@ -57,6 +57,7 @@ static const char *flow_keys[FLOW_KEY_MAX+1] = {
[FLOW_KEY_SKUID] = "sk-uid",
[FLOW_KEY_SKGID] = "sk-gid",
[FLOW_KEY_VLAN_TAG] = "vlan-tag",
+ [FLOW_KEY_RXHASH] = "rxhash",
};
static int flow_parse_keys(__u32 *keys, __u32 *nkeys, char *argv)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iproute2: tc: f_flow: add key rxhash
2010-08-21 16:30 [PATCH] iproute2: tc: f_flow: add key rxhash Changli Gao
@ 2010-08-21 21:42 ` jamal
2010-11-30 17:58 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: jamal @ 2010-08-21 21:42 UTC (permalink / raw)
To: Changli Gao; +Cc: Stephen Hemminger, netdev
On Sun, 2010-08-22 at 00:30 +0800, Changli Gao wrote:
> We can use rxhash to classify the traffic into flows. As rxhash maybe
> supplied by NIC or RPS, it is cheaper.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iproute2: tc: f_flow: add key rxhash
2010-08-21 21:42 ` jamal
@ 2010-11-30 17:58 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2010-11-30 17:58 UTC (permalink / raw)
To: hadi; +Cc: Changli Gao, netdev
On Sat, 21 Aug 2010 17:42:17 -0400
jamal <hadi@cyberus.ca> wrote:
> On Sun, 2010-08-22 at 00:30 +0800, Changli Gao wrote:
> > We can use rxhash to classify the traffic into flows. As rxhash maybe
> > supplied by NIC or RPS, it is cheaper.
> >
> > Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>
> Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
>
>
> cheers,
> jamal
>
Applied
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-30 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-21 16:30 [PATCH] iproute2: tc: f_flow: add key rxhash Changli Gao
2010-08-21 21:42 ` jamal
2010-11-30 17:58 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).