From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-kernel@vger.kernel.org
Cc: "Grant Likely" <grant.likely@secretlab.ca>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Paul Mundt" <lethal@linux-sh.org>,
"Magnus Damm" <damm@opensource.se>,
"Kevin Hilman" <khilman@deeprootsystems.com>,
"Eric Miao" <eric.y.miao@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH] driver core: platform_bus: allow runtime override of dev_pm_ops
Date: Mon, 23 Aug 2010 08:28:16 -0700 [thread overview]
Message-ID: <1282577310-10430-1-git-send-email-khilman@deeprootsystems.com> (raw)
From: Kevin Hilman <khilman@ti.com>
Currently, the platform_bus allows customization of several of the
busses dev_pm_ops methods by using weak symbols so that platform code
can override them. The weak-symbol approach is not scalable when
wanting to support multiple platforms in a single kernel binary.
Instead, provide __init methods for platform code to customize the
dev_pm_ops methods at runtime.
NOTE: after these dynamic methods are merged, the weak symbols should
be removed from drivers/base/platform.c. AFAIK, this will only
affect SH and sh-mobile which should be converted to use this
runtime approach instead of the weak symbols. After SH &
sh-mobile are converted, the weak symobols could be removed.
Tested on OMAP3.
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
Apolgies for duplicate mails. I fat-fingered the LKML list addr the first try.
drivers/base/platform.c | 16 ++++++++++++++++
include/linux/platform_device.h | 3 +++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index c6c933f..a7d8a00 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -976,6 +976,22 @@ struct bus_type platform_bus_type = {
};
EXPORT_SYMBOL_GPL(platform_bus_type);
+const struct dev_pm_ops * __init platform_bus_get_pm_ops(void)
+{
+ struct bus_type *bus = &platform_bus_type;
+
+ return bus->pm;
+}
+
+int __init platform_bus_set_pm_ops(struct dev_pm_ops *pm)
+{
+ struct bus_type *bus = &platform_bus_type;
+
+ bus->pm = pm;
+
+ return 0;
+}
+
int __init platform_bus_init(void)
{
int error;
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index d7ecad0..4bce2c9 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -138,6 +138,9 @@ extern struct platform_device *platform_create_bundle(struct platform_driver *dr
struct resource *res, unsigned int n_res,
const void *data, size_t size);
+extern const struct dev_pm_ops * __init platform_bus_get_pm_ops(void);
+extern int __init platform_bus_set_pm_ops(struct dev_pm_ops *pm);
+
/* early platform driver interface */
struct early_platform_driver {
const char *class_str;
--
1.7.2.1
next reply other threads:[~2010-08-23 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 15:28 Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 15:05 [PATCH] driver core: platform_bus: allow runtime override of dev_pm_ops Kevin Hilman
2010-08-23 15:12 ` Grant Likely
2010-08-23 15:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282577310-10430-1-git-send-email-khilman@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=damm@opensource.se \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).