Re: [PATCH] netdev: re-expose net_device_stats to user headers

Stephen Hemminger
2010-08-23T16:17:53Z

On Mon, 23 Aug 2010 16:43:23 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:

> On Mon, 2010-08-23 at 08:32 -0700, Stephen Hemminger wrote:
> > This commit broke iproute2 build:
> >
> > commit be1f3c2c027cc5ad735df6a45a542ed1db7ec48b
> > Author: Ben Hutchings <bhutchings@solarflare.com>
> > Date: Tue Jun 8 07:19:54 2010 +0000
> >
> > net: Enable 64-bit net device statistics on 32-bit architectures
> >
> > Use struct rtnl_link_stats64 as the statistics structure.
> >
> > Iproute2 uses a the kernel exported headers, and the structure
> > net_device_stats which is part of the netlink IFLA_STATS message
> > was no longer exposed.
> [...]
>
> This is not true; the kernel uses struct rtnl_link_stats for IFLA_STATS.
> AFAICS the only reference to struct net_device_stats in iproute2 is:
>
> misc/ifstat.c:51:#define MAXS (sizeof(struct net_device_stats)/sizeof(unsigned long))
>
> This should be changed to refer to the structure that is actually used.

Ok.