From: Eric Dumazet <eric.dumazet@gmail.com>
To: Lal <learner.kernel@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: RPS patch questions
Date: Wed, 25 Aug 2010 15:16:50 +0200 [thread overview]
Message-ID: <1282742210.2487.277.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTikXLwDA5cTevWiBRf+6BvZFEs+YSVqZk7wJLEjq@mail.gmail.com>
Le mercredi 25 août 2010 à 18:05 +0530, Lal a écrit :
> I am evaluating RPS patch from Tom Herbert. I have some questions
> regarding this patch.
>
> 1. Can __smp_call_function_single be called from bottom half handler?
> I presume, yes.
>
right.
> 2. I am working on 2.6.21 kernel which have neither
> __smp_call_function_single nor smp_call_function_single. I used
> smp_call_function_single from some other kernel version but this too
> can not be called from bottom half handler (just like
> smp_call_function). Did somebody try to write such function for 2.6.21
> (or older kernel) which can be called from bottom halves?
2.6.21 is too old for us ;)
>
> 3. One option I've is to upgrade to 2.6.27 kernel which has
> __smp_call_function_single. I see a comment that this function must
> not be called with interrupt disabled. Does it mean it can be called
> from bottom half handler?
>
__smp_call_function_single must be called with hard irqs enabled.
bottom half handlers (softirqs) do run with hard irqs enabled.
prev parent reply other threads:[~2010-08-25 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 12:35 RPS patch questions Lal
2010-08-25 13:16 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282742210.2487.277.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=learner.kernel@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox