* [PATCH] qlge: reset the chip before freeing the buffers
@ 2010-08-26 18:27 leitao
2010-08-26 20:19 ` Ron Mercer
0 siblings, 1 reply; 3+ messages in thread
From: leitao @ 2010-08-26 18:27 UTC (permalink / raw)
To: ron.mercer; +Cc: netdev, ying.lok, Breno Leitao
Qlge is freeing the buffers before stopping the card DMA, and
this can cause some severe error, as a EEH event on PPC.
This patch just stop the card and then free the resources.
Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
---
drivers/net/qlge/qlge_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 5a24521..2e0ca39 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -3926,12 +3926,12 @@ static int ql_adapter_down(struct ql_adapter *qdev)
for (i = 0; i < qdev->rss_ring_count; i++)
netif_napi_del(&qdev->rx_ring[i].napi);
- ql_free_rx_buffers(qdev);
-
status = ql_adapter_reset(qdev);
if (status)
netif_err(qdev, ifdown, qdev->ndev, "reset(func #%d) FAILED!\n",
qdev->func);
+ ql_free_rx_buffers(qdev);
+
return status;
}
--
1.6.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qlge: reset the chip before freeing the buffers
2010-08-26 18:27 [PATCH] qlge: reset the chip before freeing the buffers leitao
@ 2010-08-26 20:19 ` Ron Mercer
2010-08-26 21:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ron Mercer @ 2010-08-26 20:19 UTC (permalink / raw)
To: leitao@linux.vnet.ibm.com; +Cc: netdev@vger.kernel.org, Ying Ping Lok
Breno,
looks good.
Thanks
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
On Thu, Aug 26, 2010 at 11:27:58AM -0700, leitao@linux.vnet.ibm.com wrote:
> Qlge is freeing the buffers before stopping the card DMA, and
> this can cause some severe error, as a EEH event on PPC.
>
> This patch just stop the card and then free the resources.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qlge: reset the chip before freeing the buffers
2010-08-26 20:19 ` Ron Mercer
@ 2010-08-26 21:10 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-08-26 21:10 UTC (permalink / raw)
To: ron.mercer; +Cc: leitao, netdev, ying.lok
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Thu, 26 Aug 2010 13:19:06 -0700
> Breno,
> looks good.
> Thanks
Please do not top-post.
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
...
> On Thu, Aug 26, 2010 at 11:27:58AM -0700, leitao@linux.vnet.ibm.com wrote:
>> Qlge is freeing the buffers before stopping the card DMA, and
>> this can cause some severe error, as a EEH event on PPC.
>>
>> This patch just stop the card and then free the resources.
>>
>> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-26 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 18:27 [PATCH] qlge: reset the chip before freeing the buffers leitao
2010-08-26 20:19 ` Ron Mercer
2010-08-26 21:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).