* [PATCH 3/7] drivers/net/atl1c: Remove double test [not found] <1283010066-20935-1-git-send-email-julia@diku.dk> @ 2010-08-28 15:41 ` Julia Lawall 2010-08-28 16:50 ` Dan Carpenter 2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall 1 sibling, 1 reply; 4+ messages in thread From: Julia Lawall @ 2010-08-28 15:41 UTC (permalink / raw) To: netdev; +Cc: kernel-janitors, linux-kernel The nic_type field is compared to athr_l2c twice. The sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @expression@ expression E; @@ ( * E || ... || E | * E && ... && E ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- This is a guess as to what the code should be. Perhaps something else should have been tested instead. drivers/net/atl1c/atl1c_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atl1c/atl1c_hw.c b/drivers/net/atl1c/atl1c_hw.c index d8501f0..919080b 100644 --- a/drivers/net/atl1c/atl1c_hw.c +++ b/drivers/net/atl1c/atl1c_hw.c @@ -480,7 +480,7 @@ int atl1c_phy_reset(struct atl1c_hw *hw) atl1c_write_phy_reg(hw, MII_DBG_DATA, 0x929D); } if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b2 - || hw->nic_type == athr_l2c || hw->nic_type == athr_l2c) { + || hw->nic_type == athr_l2c) { atl1c_write_phy_reg(hw, MII_DBG_ADDR, 0x29); atl1c_write_phy_reg(hw, MII_DBG_DATA, 0xB6DD); } ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/7] drivers/net/atl1c: Remove double test 2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: Remove double test Julia Lawall @ 2010-08-28 16:50 ` Dan Carpenter 2010-08-28 20:10 ` Luis R. Rodriguez 0 siblings, 1 reply; 4+ messages in thread From: Dan Carpenter @ 2010-08-28 16:50 UTC (permalink / raw) To: Julia Lawall; +Cc: netdev, kernel-janitors, linux-kernel, Jie.Yang, lrodriguez I added the Atheros people to the CC list. Jie Yang should know. regards, dan carpenter On Sat, Aug 28, 2010 at 05:41:02PM +0200, Julia Lawall wrote: > The nic_type field is compared to athr_l2c twice. > > The sematic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @expression@ > expression E; > @@ > > ( > * E > || ... || E > | > * E > && ... && E > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > This is a guess as to what the code should be. Perhaps something else > should have been tested instead. > > drivers/net/atl1c/atl1c_hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/atl1c/atl1c_hw.c b/drivers/net/atl1c/atl1c_hw.c > index d8501f0..919080b 100644 > --- a/drivers/net/atl1c/atl1c_hw.c > +++ b/drivers/net/atl1c/atl1c_hw.c > @@ -480,7 +480,7 @@ int atl1c_phy_reset(struct atl1c_hw *hw) > atl1c_write_phy_reg(hw, MII_DBG_DATA, 0x929D); > } > if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b2 > - || hw->nic_type == athr_l2c || hw->nic_type == athr_l2c) { > + || hw->nic_type == athr_l2c) { > atl1c_write_phy_reg(hw, MII_DBG_ADDR, 0x29); > atl1c_write_phy_reg(hw, MII_DBG_DATA, 0xB6DD); > } > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/7] drivers/net/atl1c: Remove double test 2010-08-28 16:50 ` Dan Carpenter @ 2010-08-28 20:10 ` Luis R. Rodriguez 0 siblings, 0 replies; 4+ messages in thread From: Luis R. Rodriguez @ 2010-08-28 20:10 UTC (permalink / raw) To: Dan Carpenter, Julia Lawall, netdev, kernel-janitors, linux-kernel, Jie.Yang On Sat, Aug 28, 2010 at 09:50:14AM -0700, Dan Carpenter wrote: > I added the Atheros people to the CC list. Jie Yang should know. > > regards, > dan carpenter > > On Sat, Aug 28, 2010 at 05:41:02PM +0200, Julia Lawall wrote: > > The nic_type field is compared to athr_l2c twice. > > > > The sematic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @expression@ > > expression E; > > @@ > > > > ( > > * E > > || ... || E > > | > > * E > > && ... && E > > ) > > // </smpl> > > > > Signed-off-by: Julia Lawall <julia@diku.dk> > > > > --- > > This is a guess as to what the code should be. Perhaps something else > > should have been tested instead. > > > > drivers/net/atl1c/atl1c_hw.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/atl1c/atl1c_hw.c b/drivers/net/atl1c/atl1c_hw.c > > index d8501f0..919080b 100644 > > --- a/drivers/net/atl1c/atl1c_hw.c > > +++ b/drivers/net/atl1c/atl1c_hw.c > > @@ -480,7 +480,7 @@ int atl1c_phy_reset(struct atl1c_hw *hw) > > atl1c_write_phy_reg(hw, MII_DBG_DATA, 0x929D); > > } > > if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b2 > > - || hw->nic_type == athr_l2c || hw->nic_type == athr_l2c) { > > + || hw->nic_type == athr_l2c) { > > atl1c_write_phy_reg(hw, MII_DBG_ADDR, 0x29); > > atl1c_write_phy_reg(hw, MII_DBG_DATA, 0xB6DD); > > } The patch is pretty obvious. Looks good. Luis ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 7/7] net/wireless: Remove double test [not found] <1283010066-20935-1-git-send-email-julia@diku.dk> 2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: Remove double test Julia Lawall @ 2010-08-28 15:41 ` Julia Lawall 1 sibling, 0 replies; 4+ messages in thread From: Julia Lawall @ 2010-08-28 15:41 UTC (permalink / raw) To: John W. Linville Cc: kernel-janitors, David S. Miller, linux-wireless, netdev, linux-kernel The same expression is tested twice and the result is the same each time. The sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @expression@ expression E; @@ ( * E || ... || E | * E && ... && E ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- net/wireless/wext-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c index 0ef17bc..4038593 100644 --- a/net/wireless/wext-core.c +++ b/net/wireless/wext-core.c @@ -611,7 +611,7 @@ struct iw_statistics *get_wireless_stats(struct net_device *dev) #endif #ifdef CONFIG_CFG80211_WEXT - if (dev->ieee80211_ptr && dev->ieee80211_ptr && + if (dev->ieee80211_ptr && dev->ieee80211_ptr->wiphy && dev->ieee80211_ptr->wiphy->wext && dev->ieee80211_ptr->wiphy->wext->get_wireless_stats) ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-28 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1283010066-20935-1-git-send-email-julia@diku.dk>
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: Remove double test Julia Lawall
2010-08-28 16:50 ` Dan Carpenter
2010-08-28 20:10 ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).