From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org
Cc: Kees Cook <kees.cook-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] wireless: fix 64K kernel heap content leak via ioctl
Date: Mon, 30 Aug 2010 19:50:02 +0200 [thread overview]
Message-ID: <1283190602.3694.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100830174018.GA3639-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
On Mon, 2010-08-30 at 10:40 -0700, Jean Tourrilhes wrote:
> Ha ! I see. It would be for regular iwpoint queries, not for
> extended NOMAX queries (scan is a extended NOMAX query).
Yeah, that took a while to sink in here too ..
> I actually like your patch better than mine, it's closer to
> the original intent of the API. Go for it ;-)
> Thanks a lot for the second pair of eyes.
And thank you for looking over my patch. I guess the real bug is still
in cfg80211 there.
Initially I considered setting iwp->length to zero, rather than
max_tokens. What do you think about doing that? The reason I decided to
use max_tokens was that somebody might look at the length value to know
how much to copy (which is OK only in NOMAX queries); but that would be
a more severe driver bug ... can't really make up my mind. We just copy
back zeroes anyway.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-30 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 21:02 [PATCH] wireless: fix 64K kernel heap content leak via ioctl Kees Cook
2010-08-27 21:22 ` Jean Tourrilhes
2010-08-27 21:43 ` Kees Cook
[not found] ` <20100827214357.GE4703-oSa+0FWJbaXR7s880joybQ@public.gmane.org>
2010-08-27 21:53 ` Jean Tourrilhes
2010-08-27 22:35 ` Luis R. Rodriguez
[not found] ` <AANLkTimeEa_=dqX5yFnYzaSaL90TfOg3=MsydG81naAC-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-27 22:39 ` Jean Tourrilhes
2010-08-27 22:51 ` Luis R. Rodriguez
2010-08-30 8:47 ` Johannes Berg
2010-08-30 8:58 ` Johannes Berg
2010-08-30 9:59 ` Johannes Berg
2010-08-30 10:24 ` [PATCH] wireless extensions: fix kernel heap content leak Johannes Berg
[not found] ` <1283163894.3691.48.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2010-08-30 18:03 ` Kees Cook
2010-08-30 18:06 ` Johannes Berg
2010-08-30 17:40 ` [PATCH] wireless: fix 64K kernel heap content leak via ioctl Jean Tourrilhes
[not found] ` <20100830174018.GA3639-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
2010-08-30 17:50 ` Johannes Berg [this message]
2010-09-15 22:48 ` [vendor-sec] " Greg KH
[not found] ` <20100915224836.GF19835-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-09-15 23:11 ` Johannes Berg
2010-09-15 23:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283190602.3694.3.camel@jlt3.sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org \
--cc=kees.cook-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).