From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with TCP packets
Date: Wed, 01 Sep 2010 19:04:46 +0200 [thread overview]
Message-ID: <1283360686.2556.381.camel@edumazet-laptop> (raw)
Many network devices can tell if an incoming frame is a TCP one for a
small cost.
Instead of feeding GRO with all packets, we could filter packets on this
information ?
This should help machines handling a mixed UDP/TCP workload, keeping gro
overhead as small as possible.
patch against tg3 as an example...
Alternative would be to set a bit "is_tcp" on napi_struct to let this
choice being done in network stack, not by each driver.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
drivers/net/tg3.c | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index bc3af78..d530a0a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -4748,13 +4748,25 @@ static int tg3_rx(struct tg3_napi *tnapi, int budget)
}
}
+ /*
+ * give to GRO stack only TCP frames, with good checksums.
+ */
+ if ((desc->type_flags & RXD_FLAG_IS_TCP) &&
+ skb->ip_summed == CHECKSUM_UNNECESSARY) {
#if TG3_VLAN_TAG_USED
- if (hw_vlan)
- vlan_gro_receive(&tnapi->napi, tp->vlgrp, vtag, skb);
- else
+ if (hw_vlan)
+ vlan_gro_receive(&tnapi->napi, tp->vlgrp, vtag, skb);
+ else
#endif
- napi_gro_receive(&tnapi->napi, skb);
-
+ napi_gro_receive(&tnapi->napi, skb);
+ } else {
+#if TG3_VLAN_TAG_USED
+ if (hw_vlan)
+ vlan_hwaccel_receive_skb(skb, tp->vlgrp, vtag);
+ else
+#endif
+ netif_receive_skb(skb);
+ }
received++;
budget--;
next reply other threads:[~2010-09-01 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 17:04 Eric Dumazet [this message]
2010-09-01 17:42 ` [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with TCP packets Stephen Hemminger
2010-09-01 17:48 ` David Miller
2010-09-01 17:55 ` Stephen Hemminger
2010-09-01 20:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283360686.2556.381.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox