From: Eric Dumazet <eric.dumazet@gmail.com>
To: leitao@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, THEMANN@de.ibm.com
Subject: Re: [PATCH] MAINTAINERS: Add ehea driver as Supported
Date: Wed, 01 Sep 2010 20:48:41 +0200 [thread overview]
Message-ID: <1283366921.2484.8.camel@edumazet-laptop> (raw)
In-Reply-To: <1283365403-20877-1-git-send-email-leitao@linux.vnet.ibm.com>
Le mercredi 01 septembre 2010 à 15:23 -0300, leitao@linux.vnet.ibm.com a
écrit :
> This change just add the IBM eHEA 10Gb network drivers as supported.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Hi Breno.
This reminds me something I noticed in this driver.
In receive path, it unconditionally sets skb->ip_summed to
CHECKSUM_UNECESSARY, for _all_ frames, and this seems very suspect.
Shouldnt cqe->inet_checksum_value be checked or something ?
Are frames with bad checksum completely ignored at hardware level ?
Thanks
next prev parent reply other threads:[~2010-09-01 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 18:23 [PATCH] MAINTAINERS: Add ehea driver as Supported leitao
2010-09-01 18:48 ` Eric Dumazet [this message]
2010-09-01 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283366921.2484.8.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=THEMANN@de.ibm.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox