netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Casey Leedom <leedom@chelsio.com>
To: netdev@vger.kernel.org
Cc: Casey Leedom <leedom@chelsio.com>, Dimitris Michailidis <dm@chelsio.com>
Subject: [PATCH net-next 3/4] cxgb3: Leave interrupts for fatal errors asserted in common code.
Date: Thu,  2 Sep 2010 16:07:31 -0700	[thread overview]
Message-ID: <1283468852-1010-3-git-send-email-leedom@chelsio.com> (raw)
In-Reply-To: <241D2F16-4F92-48DD-A904-832771B2F4B4@chelsio.com>

Platform code needs to deal with them now.

Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: Casey Leedom <leedom@chelsio.com>
---
 drivers/net/cxgb3/t3_hw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
index 14a5664..d307c9d 100644
--- a/drivers/net/cxgb3/t3_hw.c
+++ b/drivers/net/cxgb3/t3_hw.c
@@ -1408,6 +1408,7 @@ static int t3_handle_intr_status(struct adapter *adapter, unsigned int reg,
 			fatal++;
 			CH_ALERT(adapter, "%s (0x%x)\n",
 				 acts->msg, status & acts->mask);
+			status &= ~acts->mask;
 		} else if (acts->msg)
 			CH_WARN(adapter, "%s (0x%x)\n",
 				acts->msg, status & acts->mask);
@@ -1843,11 +1844,10 @@ static int mac_intr_handler(struct adapter *adap, unsigned int idx)
 		t3_os_link_fault_handler(adap, idx);
 	}
 
-	t3_write_reg(adap, A_XGM_INT_CAUSE + mac->offset, cause);
-
 	if (cause & XGM_INTR_FATAL)
 		t3_fatal_err(adap);
 
+	t3_write_reg(adap, A_XGM_INT_CAUSE + mac->offset, cause);
 	return cause != 0;
 }
 
-- 
1.7.0.4


  parent reply	other threads:[~2010-09-02 23:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-02 23:04 [PATCH net-next 0/4] cxgb3: new code to deal with adapter parity errors Casey Leedom
2010-09-02 23:07 ` [PATCH net-next 1/4] cxgb3: Add register bit definition for Fatal Parity Error Casey Leedom
2010-09-02 23:07 ` [PATCH net-next 2/4] cxgb3: Set FATALPERREN Casey Leedom
2010-09-02 23:07 ` Casey Leedom [this message]
2010-09-02 23:07 ` [PATCH net-next 4/4] cxgb3: Avoid flush_workqueue() deadlock Casey Leedom
2010-09-03 17:04 ` [PATCH net-next 0/4] cxgb3: new code to deal with adapter parity errors David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283468852-1010-3-git-send-email-leedom@chelsio.com \
    --to=leedom@chelsio.com \
    --cc=dm@chelsio.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).