public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Diego Elio Pettenò" <flameeyes@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sctp: implement SIOCINQ ioctl() (take 2)
Date: Fri, 03 Sep 2010 15:28:16 +0200	[thread overview]
Message-ID: <1283520496.2453.784.camel@edumazet-laptop> (raw)
In-Reply-To: <1283517564.8231.0.camel@yamato.local>

Le vendredi 03 septembre 2010 à 14:39 +0200, Diego Elio Pettenò a
écrit :
> Il giorno ven, 03/09/2010 alle 08.55 +0200, Eric Dumazet ha scritto:
> > 
> > 
> > why use an 'unsigned long', since user pointer is a 'int *' ? 
> 
> I really just picked up the basic SIOCINQ from UDP/RDP
> 

I see, dont copy it then :)

net/ipv4/udp.c is right :

        case SIOCOUTQ:
        {
                int amount = sk_wmem_alloc_get(sk);

                return put_user(amount, (int __user *)arg);
        }

        case SIOCINQ:
        {
                unsigned int amount = first_packet_length(sk);

                if (amount)
                        /*
                         * We will only return the amount
                         * of this packet since that is all
                         * that will be read.
                         */
                        amount -= sizeof(struct udphdr);

                return put_user(amount, (int __user *)arg);
        }


Lets try to make it right too for sctp ;)

Thanks



      reply	other threads:[~2010-09-03 13:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-03  1:14 [PATCH] sctp: implement SIOCINQ ioctl() (take 2) Diego Elio Pettenò
2010-09-03  2:03 ` Shan Wei
2010-09-03  6:55 ` Eric Dumazet
2010-09-03 12:39   ` Diego Elio Pettenò
2010-09-03 13:28     ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283520496.2453.784.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=flameeyes@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox