From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] UNIX: Do not loop forever at unix_autobind().
Date: Sat, 04 Sep 2010 12:55:29 +0200 [thread overview]
Message-ID: <1283597729.3402.16.camel@edumazet-laptop> (raw)
In-Reply-To: <201009040931.o849VstI061086@www262.sakura.ne.jp>
Le samedi 04 septembre 2010 à 18:31 +0900, Tetsuo Handa a écrit :
> + cond_resched();
> + /* Give up if all names seems to be in use. */
> + if (retries++ == 0xFFFFF) {
> + err = -ENOMEM;
> + kfree(addr);
> + goto out;
> + }
> goto retry;
> }
> addr->hash ^= sk->sk_type;
Yes, but please use a different error code, its not ENOMEM...
maybe EBUSY or ENOSPC ...
next prev parent reply other threads:[~2010-09-04 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 12:01 About unix_autobind() Tetsuo Handa
2010-08-21 12:34 ` Changli Gao
2010-08-30 13:27 ` [PATCH] UNIX: Do not loop forever at unix_autobind() Tetsuo Handa
2010-09-01 19:47 ` Eric Dumazet
2010-09-04 6:58 ` Tetsuo Handa
2010-09-04 7:11 ` Eric Dumazet
2010-09-04 7:40 ` Tetsuo Handa
2010-09-04 8:24 ` Eric Dumazet
2010-09-04 9:31 ` Tetsuo Handa
2010-09-04 10:55 ` Eric Dumazet [this message]
2010-09-04 11:34 ` Tetsuo Handa
2010-09-07 1:45 ` David Miller
2010-09-04 11:52 ` Michał Mirosław
2010-09-01 21:33 ` How can OOM killer detect process consuming much kernel memory? Tetsuo Handa
2010-09-01 22:25 ` David Rientjes
2010-09-03 6:32 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283597729.3402.16.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox