* [PATCH] drivers: isdn: capi: use simple_strtol to convert numbers
@ 2010-09-07 15:14 Andy Shevchenko
2010-09-08 21:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2010-09-07 15:14 UTC (permalink / raw)
To: linux-kernel, davem; +Cc: Andy Shevchenko, Karsten Keil, Tilman Schmidt, netdev
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: Tilman Schmidt <tilman@imap.cc>
Cc: netdev@vger.kernel.org
---
drivers/isdn/capi/capidrv.c | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
index 2978bda..e54e79d4 100644
--- a/drivers/isdn/capi/capidrv.c
+++ b/drivers/isdn/capi/capidrv.c
@@ -1515,8 +1515,13 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
while (*s) {
int digit1 = 0;
int digit2 = 0;
- if (!isdigit(*s)) return -3;
- while (isdigit(*s)) { digit1 = digit1*10 + (*s - '0'); s++; }
+ char *endp;
+
+ digit1 = simple_strtoul(s, &endp, 10);
+ if (s == endp)
+ return -3;
+ s = endp;
+
if (digit1 <= 0 || digit1 > 30) return -4;
if (*s == 0 || *s == ',' || *s == ' ') {
bmask |= (1 << digit1);
@@ -1526,8 +1531,12 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
}
if (*s != '-') return -5;
s++;
- if (!isdigit(*s)) return -3;
- while (isdigit(*s)) { digit2 = digit2*10 + (*s - '0'); s++; }
+
+ digit2 = simple_strtoul(s, &endp, 10);
+ if (s == endp)
+ return -3;
+ s = endp;
+
if (digit2 <= 0 || digit2 > 30) return -4;
if (*s == 0 || *s == ',' || *s == ' ') {
if (digit1 > digit2)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: isdn: capi: use simple_strtol to convert numbers
2010-09-07 15:14 [PATCH] drivers: isdn: capi: use simple_strtol to convert numbers Andy Shevchenko
@ 2010-09-08 21:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-08 21:10 UTC (permalink / raw)
To: andy.shevchenko; +Cc: linux-kernel, isdn, tilman, netdev
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 7 Sep 2010 18:14:30 +0300
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-08 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 15:14 [PATCH] drivers: isdn: capi: use simple_strtol to convert numbers Andy Shevchenko
2010-09-08 21:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).