From: Eric Dumazet <eric.dumazet@gmail.com>
To: jovi zhang <bookjovi@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Johannes Berg <johannes.berg@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@openvz.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: Fix kfree NULL pointer
Date: Wed, 08 Sep 2010 07:55:24 +0200 [thread overview]
Message-ID: <1283925324.2634.843.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTim+=vj+k3=1hzT3=J4ssOopp5Eq=g+DHis=pZFN@mail.gmail.com>
Le mercredi 08 septembre 2010 à 13:33 +0800, jovi zhang a écrit :
> YES, maybe kfree(NULL) is legal, but I cannot see there have any need
> to invoke kfree(NULL) in this function.
> Also I check kfree usage in other code, I havn't find any kfree(NULL) usage.
We have hundred call sites doing kfree(NULL), if it makes code shorter.
Its usually code path handling exceptions (errors if you prefer), and we
prefer to use ugly gotos, and even kfree(NULL), to make it as short as
possible.
next prev parent reply other threads:[~2010-09-08 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTikp0m8cQYfEBHP_E8XpGZqdMj6Cr4M=aWCnei=X@mail.gmail.com>
2010-09-08 5:19 ` [PATCH] netlink: Fix kfree NULL pointer Eric Dumazet
2010-09-08 5:33 ` jovi zhang
2010-09-08 5:53 ` David Miller
2010-09-08 5:54 ` Eric W. Biederman
2010-09-08 5:55 ` Eric Dumazet [this message]
2010-09-08 6:14 ` jovi zhang
2010-09-08 5:13 jovi zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283925324.2634.843.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=adobriyan@openvz.org \
--cc=bookjovi@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox