From: Joe Perches <joe@perches.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 4/7 v3] au1000-eth: fix bad printk usages
Date: Wed, 08 Sep 2010 14:24:51 -0700 [thread overview]
Message-ID: <1283981091.2479.51.camel@Joe-Laptop> (raw)
In-Reply-To: <201009082311.45685.florian@openwrt.org>
On Wed, 2010-09-08 at 23:11 +0200, Florian Fainelli wrote:
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> @@ -1199,7 +1203,8 @@ static int __devinit au1000_probe(struct platform_device *pdev)
> netdev_info(dev, "Au1xx0 Ethernet found at 0x%lx, irq %d\n",
> (unsigned long)base->start, irq);
> if (version_printed++ == 0)
> - printk("%s version %s %s\n", DRV_NAME, DRV_VERSION, DRV_AUTHOR);
> + pr_info("%s version %s %s\n",
> + DRV_NAME, DRV_VERSION, DRV_AUTHOR);
You could also remove version_printed and use
printk_once(KERN_INFO etc...)
next prev parent reply other threads:[~2010-09-08 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 21:11 [PATCH 4/7 v3] au1000-eth: fix bad printk usages Florian Fainelli
2010-09-08 21:24 ` Joe Perches [this message]
2010-09-10 4:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283981091.2479.51.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).