Re: [PATCH] ixgbe: add GRO to vlan_features

Brandon Philips
2010-09-15T16:41:40Z

On 21:35 Tue 14 Sep 2010, David Miller wrote:
> From: Brandon Philips <bphilips@suse.de>
> Date: Tue, 14 Sep 2010 18:50:53 -0700
>
> > When running a vlan -> bridge -> domU setup I was noticing poor RX
> > performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set
> > in vlan_features and thus GRO is off by default for vlans.
> >
> > I see no reason why the other drivers shouldn't be fixed. If this is OK
> > I will go off and fix the rest.
> >
> > Signed-off-by: Brandon Philips <bphilips@suse.de>
>
> I think it should be set, but why don't we do this another way?
>
> This feature is a software feature, essentially, so if it is published
> in netdev->features we can simply propagate it automatically to
> netdev->vlan_features at device registry time in the core networking.

Agreed. I will just send a patch to vlan_dev.c then.