Re: [PATCH] net: enable GRO by default for vlan devices

Stephen Hemminger
2010-09-16T01:16:16Z

On Thu, 16 Sep 2010 00:28:11 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Le jeudi 16 septembre 2010 à 00:03 +0200, Eric Dumazet a écrit :
> > Le mercredi 15 septembre 2010 à 12:24 -0700, Brandon Philips a écrit :
> > > Currently vlan devices don't have GRO by default as none of the Ethernet
> > > drivers add NETIF_F_GRO to their vlan_features.
> > >
> > > As GRO is a software feature add GRO to dev->vlan_features in
> > > register_netdevice() and let vlan_dev_init() take care that it gets
> > > enabled only when dev->features has NETIF_F_GRO too.
> > >
> > > Signed-off-by: Brandon Philips <bphilips@suse.de>
> > >
> >
> > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> >
>
> BTW, we have a similar problem for bonding ( GRO is disabled )
>
> # ethtool -K bond0 gro off
> # ethtool -K bond0 gro on
> Cannot set device GRO settings: Invalid argument
>
> Same for vlans on top of bond0

Bridge has same problem as well.

--

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired