netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
	"Benjamin Li" <benli@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] drivers/net/tg3.c: Raise Jumbo Frame MTU to 9216?
Date: Wed, 15 Sep 2010 10:57:34 -0700	[thread overview]
Message-ID: <1284573454.8929.221.camel@HP1> (raw)
In-Reply-To: <1284572516.10223.12.camel@Joe-Laptop>


On Wed, 2010-09-15 at 10:41 -0700, Joe Perches wrote:
> The TG3 apparently supports 9K frame sizes.
> 
> http://www.broadcom.com/collateral/pb/5704C-PB05-R.pdf
> 
> Is exactly 9000 a hardware limit?
> 
> Should the jumbo frame MTU be raised to 9216 or 9216
> less the size of MAC, VLAN, IP and TCP headers?

9000 has been the de facto standard, has it been changed recently?

Anyway, we've never done any testing on 9216.  As it uses up to 2 more
internal mbufs per packet, there may not be sufficient buffers inside
the chip for optimal operations.  At best, some water marks will need to
be tweaked.  The hardware statistics counters (ethtool -S) also may not
work for packets bigger than 9022 bytes.

> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 9f6ffff..3727070 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -95,7 +95,7 @@
>  /* hardware minimum and maximum for a single frame's data payload */
>  #define TG3_MIN_MTU			60
>  #define TG3_MAX_MTU(tp)	\
> -	((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) ? 9000 : 1500)
> +	((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) ? 9216 : 1500)
>  
>  /* These numbers seem to be hard coded in the NIC firmware somehow.
>   * You can't change the ring sizes, but you can change where you place
> 
> 
> 

  reply	other threads:[~2010-09-15 17:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 17:41 [RFC PATCH] drivers/net/tg3.c: Raise Jumbo Frame MTU to 9216? Joe Perches
2010-09-15 17:57 ` Michael Chan [this message]
2010-09-15 19:14   ` Joe Perches
2010-09-15 19:31     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284573454.8929.221.camel@HP1 \
    --to=mchan@broadcom.com \
    --cc=benli@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcarlson@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).