From: Dan Rosenberg <drosenberg@vsecurity.com>
To: divy@chelsio.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
security@kernel.org
Subject: [PATCH v2] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory
Date: Wed, 15 Sep 2010 17:43:12 -0400 [thread overview]
Message-ID: <1284586992.6275.93.camel@dan> (raw)
Fixed formatting (tabs and line breaks).
The CHELSIO_GET_QSET_NUM device ioctl allows unprivileged users to read
4 bytes of uninitialized stack memory, because the "addr" member of the
ch_reg struct declared on the stack in cxgb_extension_ioctl() is not
altered or zeroed before being copied back to the user. This patch
takes care of it.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
--- linux-2.6.35.4.orig/drivers/net/cxgb3/cxgb3_main.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/cxgb3/cxgb3_main.c 2010-09-14 21:24:34.369511115 -0400
@@ -2296,6 +2296,8 @@ static int cxgb_extension_ioctl(struct n
case CHELSIO_GET_QSET_NUM:{
struct ch_reg edata;
+ memset(&edata, 0, sizeof(struct ch_reg));
+
edata.cmd = CHELSIO_GET_QSET_NUM;
edata.val = pi->nqsets;
if (copy_to_user(useraddr, &edata, sizeof(edata)))
next reply other threads:[~2010-09-15 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:43 Dan Rosenberg [this message]
2010-09-16 15:54 ` [PATCH v2] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory Steven Rostedt
2010-09-17 4:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284586992.6275.93.camel@dan \
--to=drosenberg@vsecurity.com \
--cc=divy@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).