From: Eric Dumazet <eric.dumazet@gmail.com>
To: Brandon Philips <bphilips@suse.de>
Cc: e1000-devel@lists.sourceforge.net, bruce.w.allan@intel.com,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: enable GRO by default for vlan devices
Date: Thu, 16 Sep 2010 00:28:11 +0200 [thread overview]
Message-ID: <1284589691.2462.85.camel@edumazet-laptop> (raw)
In-Reply-To: <1284588203.2462.81.camel@edumazet-laptop>
Le jeudi 16 septembre 2010 à 00:03 +0200, Eric Dumazet a écrit :
> Le mercredi 15 septembre 2010 à 12:24 -0700, Brandon Philips a écrit :
> > Currently vlan devices don't have GRO by default as none of the Ethernet
> > drivers add NETIF_F_GRO to their vlan_features.
> >
> > As GRO is a software feature add GRO to dev->vlan_features in
> > register_netdevice() and let vlan_dev_init() take care that it gets
> > enabled only when dev->features has NETIF_F_GRO too.
> >
> > Signed-off-by: Brandon Philips <bphilips@suse.de>
> >
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
BTW, we have a similar problem for bonding ( GRO is disabled )
# ethtool -K bond0 gro off
# ethtool -K bond0 gro on
Cannot set device GRO settings: Invalid argument
Same for vlans on top of bond0
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2010-09-15 22:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 1:50 [PATCH] ixgbe: add GRO to vlan_features Brandon Philips
2010-09-15 4:35 ` David Miller
2010-09-15 16:37 ` [PATCH] vlan: enable GRO if real_dev supports it Brandon Philips
2010-09-15 17:08 ` Eric Dumazet
2010-09-15 17:14 ` David Miller
2010-09-15 17:24 ` Ben Hutchings
2010-09-15 17:29 ` David Miller
2010-09-15 19:24 ` [PATCH] net: enable GRO by default for vlan devices Brandon Philips
2010-09-15 22:03 ` Eric Dumazet
2010-09-15 22:28 ` Eric Dumazet [this message]
2010-09-16 1:16 ` Stephen Hemminger
2010-09-16 5:51 ` [E1000-devel] " David Miller
2010-09-16 6:21 ` Stephen Hemminger
2010-09-16 6:38 ` David Miller
2010-09-16 6:42 ` Eric Dumazet
2010-09-16 8:11 ` [PATCH] ethtool: change ethtool_set_gro() to use ethtool_op_get_rx_csum Eric Dumazet
2010-09-17 18:57 ` David Miller
2010-09-17 19:25 ` [PATCH] bonding: enable gro by default Eric Dumazet
2010-09-17 23:54 ` David Miller
2010-09-16 5:32 ` [PATCH] net: enable GRO by default for vlan devices David Miller
2010-09-15 18:59 ` [PATCH] vlan: enable GRO if real_dev supports it Brandon Philips
2010-09-15 16:38 ` [PATCH] ixgbe: add GRO to vlan_features Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284589691.2462.85.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=bphilips@suse.de \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox