From: Eric Dumazet <eric.dumazet@gmail.com>
To: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, anirban.chakraborty@qlogic.com
Subject: Re: [PATCH NEXT 1/5] qlcnic: support vlan rx accleration
Date: Thu, 16 Sep 2010 15:36:49 +0200 [thread overview]
Message-ID: <1284644209.3352.35.camel@edumazet-laptop> (raw)
In-Reply-To: <1284642872-27832-2-git-send-email-amit.salecha@qlogic.com>
Le jeudi 16 septembre 2010 à 06:14 -0700, Amit Kumar Salecha a écrit :
> - if (unlikely(adapter->pvid)) {
> - if (qlcnic_check_rx_tagging(adapter, skb)) {
> - adapter->stats.rxdropped++;
> - dev_kfree_skb_any(skb);
> - return buffer;
> - }
> + if (unlikely(qlcnic_check_rx_tagging(adapter, skb, &vid))) {
> + adapter->stats.rxdropped++;
> + dev_kfree_skb_any(skb);
Its a bit strange you use dev_kfree_skb_any(skb) here.
We run in NAPI mode, so you can use dev_kfree_skb().
> + return buffer;
> }
>
> skb->protocol = eth_type_trans(skb, netdev);
>
> - napi_gro_receive(&sds_ring->napi, skb);
> + if ((vid != 0xffff) && adapter->vlgrp)
> + vlan_hwaccel_receive_skb(skb, adapter->vlgrp, vid);
> + else
> + napi_gro_receive(&sds_ring->napi, skb);
next prev parent reply other threads:[~2010-09-16 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 13:14 [PATCH NEXT 0/5]qlcnic: vlan rx accleration support Amit Kumar Salecha
2010-09-16 13:14 ` [PATCH NEXT 1/5] qlcnic: support vlan rx accleration Amit Kumar Salecha
2010-09-16 13:26 ` Eric Dumazet
2010-09-16 13:36 ` Eric Dumazet [this message]
2010-09-16 13:14 ` [PATCH NEXT 2/5] qlcnic: vlan gro support Amit Kumar Salecha
2010-09-16 13:14 ` [PATCH NEXT 3/5] qlcnic: vlan lro support Amit Kumar Salecha
2010-09-16 13:27 ` Eric Dumazet
2010-09-16 18:13 ` Amit Salecha
2010-09-17 7:10 ` Amit Salecha
2010-09-17 7:34 ` "Oleg A. Arkhangelsky"
2010-09-17 8:28 ` Eric Dumazet
2010-09-16 13:14 ` [PATCH NEXT 4/5] qlcnic: remove fw version check Amit Kumar Salecha
2010-09-16 13:14 ` [PATCH NEXT 5/5] qlcnic: update version 5.0.10 Amit Kumar Salecha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284644209.3352.35.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox