[PATCH 00/12] more BKL removal after get_sb pushdown

[PATCH 00/12] more BKL removal after get_sb pushdown

[Arnd Bergmann]

These patches have not been posted yet, I did some of them
only when going through the list of remaining BKL users and
found them to be simple to fix myself.

Most of these patches only apply on top of the pushdown into
the get_sb operation, which is now in linux-next, so I'm
planning to keep them in the same series instead of
going through maintainer trees.

The full series can be found in
git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl.git vfs

Arnd Bergmann (12):
  BKL: Remove BKL from usbfs
  BKL: Remove BKL from fat
  BKL: Remove BKL from isofs
  BKL: Remove BKL from autofs4
  BKL: Remove BKL from ReiserFS
  BKL: Remove BKL from capifs
  BKL: Remove BKL from USB gadgetfs
  BKL: Remove BKL from afs
  BKL: Remove BKL from ecryptfs
  BKL: Remove BKL from jffs2
  BKL: Remove BKL from squashfs
  BKL: Remove BKL from OCFS2

 drivers/isdn/capi/capifs.c |    8 +-------
 drivers/usb/core/inode.c   |    6 ------
 drivers/usb/gadget/inode.c |   13 ++-----------
 fs/afs/super.c             |   10 ----------
 fs/autofs4/root.c          |   12 +++++++-----
 fs/ecryptfs/file.c         |    3 ---
 fs/ecryptfs/main.c         |    4 ----
 fs/fat/inode.c             |    5 -----
 fs/fat/namei_msdos.c       |    7 +++----
 fs/fat/namei_vfat.c        |    7 +++----
 fs/isofs/dir.c             |    6 +++---
 fs/isofs/inode.c           |   16 ++++++----------
 fs/isofs/namei.c           |    8 ++++----
 fs/isofs/rock.c            |    8 ++++----
 fs/jffs2/fs.c              |    4 ----
 fs/jffs2/super.c           |   12 +-----------
 fs/ocfs2/dlmfs/dlmfs.c     |    9 +--------
 fs/ocfs2/stack_user.c      |    3 ---
 fs/ocfs2/super.c           |   12 ------------
 fs/reiserfs/super.c        |    6 ------
 fs/squashfs/super.c        |   11 -----------
 21 files changed, 35 insertions(+), 135 deletions(-)

Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Jan Blunck <jblunck@infradead.org>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Jan Blunck <jblunck@infradead.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: reiserfs-devel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org
Cc: linux-afs@lists.infradead.org
Cc: David Howells <dhowells@redhat.com>
Cc: Dustin Kirkland <kirkland@canonical.com>
Cc: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Cc: ecryptfs-devel@lists.launchpad.net
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: linux-fsdevel@vger.kernel.org

[PATCH 06/12] BKL: Remove BKL from capifs

[Arnd Bergmann]

The BKL is only used in fill_super, which is  protected by the superblocks
s_umount rw_semaphore. Therefore it is safe to remove the BKL entirely.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org
---
 drivers/isdn/capi/capifs.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c
index c559b52..b0dcdbc 100644
--- a/drivers/isdn/capi/capifs.c
+++ b/drivers/isdn/capi/capifs.c
@@ -17,7 +17,6 @@
 #include <linux/init.h>
 #include <linux/ctype.h>
 #include <linux/sched.h>	/* current */
-#include <linux/smp_lock.h>	/* For lock_kernel() */
 
 #include "capifs.h"
 
@@ -100,8 +99,6 @@ capifs_fill_super(struct super_block *s, void *data, int silent)
 {
 	struct inode * inode;
 
-	lock_kernel();
-
 	s->s_blocksize = 1024;
 	s->s_blocksize_bits = 10;
 	s->s_magic = CAPIFS_SUPER_MAGIC;
@@ -119,15 +116,12 @@ capifs_fill_super(struct super_block *s, void *data, int silent)
 	inode->i_nlink = 2;
 
 	s->s_root = d_alloc_root(inode);
-	if (s->s_root) {
-		unlock_kernel();
+	if (s->s_root)
 		return 0;
-	}
 
 	printk("capifs: get root dentry failed\n");
 	iput(inode);
 fail:
-	unlock_kernel();
 	return -ENOMEM;
 }
 
-- 
1.7.1

Re: [PATCH 06/12] BKL: Remove BKL from capifs

[David Miller]

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 16 Sep 2010 19:46:19 +0200

> The BKL is only used in fill_super, which is  protected by the superblocks
> s_umount rw_semaphore. Therefore it is safe to remove the BKL entirely.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: netdev@vger.kernel.org

I've searched Linus's tree, net-2.6, and net-next-2.6 and I cannot
find one reference to lock_kernel() in drivers/isdn/capi/capifs.c
in any of them.

What did you write this patch against?

Re: [PATCH 06/12] BKL: Remove BKL from capifs

[Arnd Bergmann]

On Saturday 18 September 2010 01:35:30 David Miller wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 16 Sep 2010 19:46:19 +0200
> 
> > The BKL is only used in fill_super, which is  protected by the superblocks
> > s_umount rw_semaphore. Therefore it is safe to remove the BKL entirely.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: netdev@vger.kernel.org
> 
> I've searched Linus's tree, net-2.6, and net-next-2.6 and I cannot
> find one reference to lock_kernel() in drivers/isdn/capi/capifs.c
> in any of them.
> 
> What did you write this patch against?

As I wrote in my [PATCH 0/12], it applies on top of the pushdown
of the BKL into the get_sb operation, and I intend to submit it
to Linus with the full series.

I agree that this particular patch is a bit pointless because
all it does is to undo the change from the pushdown. I guess
that at the time when the first patch was written, the BKL
was still present in other parts of capifs.

	Arnd