From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B8FCC38A2D for ; Thu, 27 Oct 2022 06:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234041AbiJ0Gf0 (ORCPT ); Thu, 27 Oct 2022 02:35:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbiJ0GfZ (ORCPT ); Thu, 27 Oct 2022 02:35:25 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 182F995ADD; Wed, 26 Oct 2022 23:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1666852522; x=1698388522; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=b5A2GFSPAKlPXSyQ/35gbyiEt3fO3+/e4osgD5ldbUQ=; b=PHJNiL8E7KZGVPds5HjkYQsXAEH9vPkRjHKpnEqJC0AW5lwhuZKc4cQH +/dKYs9c62+NUilPjaJvnHdaP2Jpzy3DQlEgf0fqo1CGerAnzVOBhG3sa oqEVXfIOg06ixlzUwa70JBNIdHPF/cHHhRzVUW5S1zZB16YDAhgIHuCNn Jcejlq1+ymZmo3ye0hszYC2moFLU2HVQ6Mi7dWPz6yH60eYcD6PpR+SJs H9NnJ8rVHKfHAgYhBLwot77yurTjFPIGDdAUpKVsGXJ6uRNA+QeHicoRV pipKXu68PhcKP7cNC50Dudg/V45RF37YxE5lKUFauPi2xpemTxMunvIPP g==; Message-ID: <128467d6-8249-9f25-21a7-777fff9854d9@axis.com> Date: Thu, 27 Oct 2022 08:35:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 From: Camel Guo Subject: Re: [RFC net-next 2/2] net: dsa: Add driver for Maxlinear GSW1XX switch To: Andrew Lunn , Krzysztof Kozlowski CC: Camel Guo , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Krzysztof Kozlowski , Paolo Abeni , Rob Herring , Russell King , Vivien Didelot , Vladimir Oltean , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Rob Herring , kernel References: <20221025135243.4038706-1-camel.guo@axis.com> <20221025135243.4038706-3-camel.guo@axis.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: se-mail06w.axis.com (10.20.40.12) To se-mail03w.axis.com (10.20.40.9) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/25/22 16:56, Andrew Lunn wrote: >> > +EXPORT_SYMBOL(gsw1xx_shutdown); >> >> 1. EXPORT_SYMBOL_GPL >> 2. Why do you do it in the first place? It's one driver, no need for >> building two modules. Same applies to other places. > > At some point, there is likely to be SPI and UART support. The > communication with the chip and the core driver will then be in > separate modules. But i agree this is not needed at the moment when it > is all linked into one. Do you suggest that currently we put the content of gsw1xx_core.c and gsw1xx_mdio.c into one file and split them later at the time when another management mode (e,g: spi) is added? Actually I kinda hope this piece of code (gsw1xx_core.c) can be reused in lantiq_gswip in short future. I tried to use the logic in lantiq_gswip directly on the gsw145 chip. Unfortunately it did not work. It seems that the GSWIP part changes a lot. > >    Andrew